1111414 - [Stingray] create UI for and apply visual to interactive notification

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[John Hu [:johnhu][:johu][:醬糊小弟]]

Create UI and apply visual to interactive notification

Comment 1

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: create notification visual

Luke,

Please review this patch since rex is fully loaded.

Because this patch depends on another which is not landed, I pushed two commits to this patch. Please only review the later one: https://github.com/huchengtw-moz/gaia/commit/e215f019a3d7d94fe06d9e91adb4b1d03efea2cb .

Comment 2

[John Hu [:johnhu][:johu][:醬糊小弟]]

Sean,

Please follow this bug to change the animation from fade-in to flying in. Thanks. I will file another bug for this one.

Comment 3

[John Hu [:johnhu][:johu][:醬糊小弟]]

cc rex,

Rex, I think you may also need to know this patch. Please see it after you finish your works.

Comment 4

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8537148 [details] [review]
create notification visual

Sorry,

I decide to add the back key support at interactive_notification.js. So, I will change the patch and reset the review flag after finished.

Comment 5

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8537148 [details] [review]
create notification visual

Luke,

I had put the "back key" support to this patch. Please review it.

Comment 6

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8537148 [details] [review]
create notification visual

All looks good. Only a few comments on GitHub. Thanks.

Comment 7

[John Hu [:johnhu][:johu][:醬糊小弟]]

merged to master:
https://github.com/mozilla-b2g/gaia/commit/7ae741bc9a365c90747b4c87573a4ecd913a6fa5

gaia-try is all passed with one intermittent error:
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=ff3862965a71