Closed Bug 1111433 Opened 5 years ago Closed 5 years ago

[text selection] Close the text dialog when the focused content gets blur

Categories

(Core :: Selection, defect, P2)

x86
macOS
defect

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: pchang, Assigned: pchang)

References

Details

Attachments

(2 files, 5 obsolete files)

This is a defect of the selectionstatechanged event dispatch logic, need to handle the 'blur' case in BrowserElementChildPreload.js
Assignee: nobody → pchang
Ehsan, right now the selectionstatechanged event dispatch logic is in BrowserElementChildPreload.js (modified by bug 1090008). 

This patch will always dispatch the blur event to text dialog. Later I will add the test case for the blur.
Attachment #8536455 - Flags: review?(ehsan.akhgari)
Attachment #8536455 - Flags: review?(ehsan.akhgari) → review+
Attached patch bug-1111433-test.patch (obsolete) — Splinter Review
add the mochitest
Attachment #8537103 - Flags: review?(ehsan.akhgari)
Attachment #8537103 - Flags: review?(ehsan.akhgari) → review+
Priority: -- → P2
Attached patch v2 mochitest (obsolete) — Splinter Review
Set the usecapture as true for RemoveEventListener
Attachment #8537103 - Attachment is obsolete: true
Attachment #8538222 - Flags: review+
(In reply to peter chang[:pchang][:peter] from comment #3)
> Created attachment 8538222 [details] [diff] [review]
> v2 mochitest
> 
> Set the usecapture as true for RemoveEventListener

Hit the crash for b2g desktop mochitest, create bug 1113524 to fix the crash.

https://tbpl.mozilla.org/?tree=Try&rev=8ced49e7387a
Depends on: 1113524
rebase
Attachment #8536455 - Attachment is obsolete: true
Attachment #8539251 - Flags: review+
Attached patch v3 mochitest (obsolete) — Splinter Review
Modify because bug 1109800 changes the timing to trigger blur event in focusManager.
Attachment #8538222 - Attachment is obsolete: true
Attachment #8539253 - Flags: review+
Depends on: 1109800
Try result is positive, wait for bug 1109800 and 1113524.
As mentioned in bug 1113524 comment 17, checking '_isContentWindowCreated' before sending out the SelectionStateChanged event.
Attachment #8539251 - Attachment is obsolete: true
Attachment #8545124 - Flags: review+
Fix the CopyPaste mochitest and disable b2g SelectionStateBlur mochitest because of bug 1097419. Will fire a follow-up bug to enable SelectionStateBlur mochitest on b2g.
Attachment #8539253 - Attachment is obsolete: true
Attachment #8545727 - Flags: review+
No longer depends on: 1113524
https://hg.mozilla.org/mozilla-central/rev/0257f42048f3
https://hg.mozilla.org/mozilla-central/rev/40f4f285ea0c
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.