Closed
Bug 1111433
Opened 9 years ago
Closed 9 years ago
[text selection] Close the text dialog when the focused content gets blur
Categories
(Core :: DOM: Selection, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: pchang, Assigned: pchang)
References
Details
Attachments
(2 files, 5 obsolete files)
2.85 KB,
patch
|
pchang
:
review+
|
Details | Diff | Splinter Review |
9.50 KB,
patch
|
pchang
:
review+
|
Details | Diff | Splinter Review |
This is a defect of the selectionstatechanged event dispatch logic, need to handle the 'blur' case in BrowserElementChildPreload.js
Assignee | ||
Updated•9 years ago
|
Blocks: CopyPasteLegacy
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → pchang
Assignee | ||
Comment 1•9 years ago
|
||
Ehsan, right now the selectionstatechanged event dispatch logic is in BrowserElementChildPreload.js (modified by bug 1090008). This patch will always dispatch the blur event to text dialog. Later I will add the test case for the blur.
Attachment #8536455 -
Flags: review?(ehsan.akhgari)
Updated•9 years ago
|
Attachment #8536455 -
Flags: review?(ehsan.akhgari) → review+
Assignee | ||
Comment 2•9 years ago
|
||
add the mochitest
Attachment #8537103 -
Flags: review?(ehsan.akhgari)
Updated•9 years ago
|
Attachment #8537103 -
Flags: review?(ehsan.akhgari) → review+
Assignee | ||
Updated•9 years ago
|
Priority: -- → P2
Assignee | ||
Comment 3•9 years ago
|
||
Set the usecapture as true for RemoveEventListener
Attachment #8537103 -
Attachment is obsolete: true
Attachment #8538222 -
Flags: review+
Assignee | ||
Comment 4•9 years ago
|
||
(In reply to peter chang[:pchang][:peter] from comment #3) > Created attachment 8538222 [details] [diff] [review] > v2 mochitest > > Set the usecapture as true for RemoveEventListener Hit the crash for b2g desktop mochitest, create bug 1113524 to fix the crash. https://tbpl.mozilla.org/?tree=Try&rev=8ced49e7387a
Assignee | ||
Comment 5•9 years ago
|
||
rebase
Attachment #8536455 -
Attachment is obsolete: true
Attachment #8539251 -
Flags: review+
Assignee | ||
Comment 6•9 years ago
|
||
Modify because bug 1109800 changes the timing to trigger blur event in focusManager.
Attachment #8538222 -
Attachment is obsolete: true
Attachment #8539253 -
Flags: review+
Assignee | ||
Comment 7•9 years ago
|
||
Try result is positive, wait for bug 1109800 and 1113524.
Assignee | ||
Comment 8•9 years ago
|
||
As mentioned in bug 1113524 comment 17, checking '_isContentWindowCreated' before sending out the SelectionStateChanged event.
Attachment #8539251 -
Attachment is obsolete: true
Attachment #8545124 -
Flags: review+
Assignee | ||
Comment 9•9 years ago
|
||
Fix the CopyPaste mochitest and disable b2g SelectionStateBlur mochitest because of bug 1097419. Will fire a follow-up bug to enable SelectionStateBlur mochitest on b2g.
Attachment #8539253 -
Attachment is obsolete: true
Attachment #8545727 -
Flags: review+
Assignee | ||
Comment 10•9 years ago
|
||
Try server is positive. https://treeherder.mozilla.org/#/jobs?repo=try&revision=66c733bc3cb5
Keywords: checkin-needed
Comment 11•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0257f42048f3 https://hg.mozilla.org/integration/mozilla-inbound/rev/40f4f285ea0c
Flags: in-testsuite+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/0257f42048f3 https://hg.mozilla.org/mozilla-central/rev/40f4f285ea0c
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in
before you can comment on or make changes to this bug.
Description
•