Closed Bug 1111785 Opened 9 years ago Closed 9 years ago

Implement ES6 7.2.2 IsArray


(Core :: JavaScript Engine, defect)

Not set





(Reporter: evilpie, Assigned: evilpie)


(Blocks 1 open bug)



(1 file, 1 obsolete file)

This is special case that allows going through a Proxy (ScriptedDirectProxy in our case) to check for arrays. Used in some places like Array.isArray, JSON.stringify etc.
Attached patch is-array (obsolete) — Splinter Review
Missing tests. The changes to JSON.stringify aren't really useful for proxies until bug 895223 is fixed.
Attachment #8539530 - Attachment is obsolete: true
Comment on attachment 8539530 [details] [diff] [review]

Review of attachment 8539530 [details] [diff] [review]:

::: js/src/jsobj.cpp
@@ +3650,5 @@
> +    if (obj->is<ProxyObject>()) {
> +        if (obj->as<ProxyObject>().handler()->isES6Proxy()) {
> +            RootedObject target(cx, obj->as<ProxyObject>().target());
> +            if (!target) {
> +                JS_ReportErrorNumber(cx, js_GetErrorMessage, nullptr, JSMSG_PROXY_REVOKED);

Rev 30 has changed this to return false instead of throwing an exception.
Awesome \o/. Thank you ziyunfei! This means we can actually simplify this function again, because we don't really need the context parameter and can just return true/false.

There is however still one problem I am aware of. Something like this is currently not working (actually after fixing bug 1115361): Array.isArray(new (newGlobal().Proxy([], {})). We could fix this by introducing a new ESClass_Array value that follows the semantics of IsArray.
I fixed this, but we need to land some tests.
Attached patch Some testsSplinter Review
Attachment #8556106 - Flags: review?(jwalden+bmo)
We will add some test for JSON.stringify in bug 1111604.
Comment on attachment 8556106 [details] [diff] [review]
Some tests

Review of attachment 8556106 [details] [diff] [review]:

::: js/src/tests/ecma_6/Array/isArray.js
@@ +18,5 @@
> +}
> +
> +revocable.revoke();
> +assertEq(Array.isArray(revocable.proxy), false);
> +assertEq(Array.isArray(proxy), false);

Bah.  I am not really a fan of these semantics.  It seems to me that touching a revoked proxy or examining anything about it, at all, should always throw.  Just as Object.isExtensible(revocable.proxy) throws, rather than returning true or false.  What do you think about getting the spec changed on the question?

Fine to land what's here for now, tho, if/until we get that changed.

@@ +23,5 @@
> +
> +var global = newGlobal();
> +var array = global.Array();
> +assertEq(Array.isArray(array), true);
> +assertEq(Array.isArray(new Proxy(array, {})), true);

assertEq(Array.isArray(new global.Proxy(array, {})), true);
Attachment #8556106 - Flags: review?(jwalden+bmo) → review+
Revoked proxies actually used to throw. Waldo said he would open a bug.
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
Filed for the spec issue, which applies to various other predicates in the spec as well.
You need to log in before you can comment on or make changes to this bug.