1112473 - 2 caret appears when long pressing the rocket bar

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Gerry Chang [:gchang]]

### Steps:
1. Go to home screen
2. Long press the rocket bar

### Expected:
1. There should be one caret

### Actual:
1. 2 carets appear and the positions of these 2 carets are different

### Reproduce rate
always

### Version:
Gaia-Rev        8ffb48c321bb9595ad437086c5eb450bc90aa714
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/8401afdb6e6c
Build-ID        20141216160204
Version         37.0a1
Device-Name     flame
FW-Release      4.4.2

Comment 1

[Gerry Chang [:gchang]]

Attachment: 2014-12-17.png

Comment 3

[Gregor Wagner [:gwagner]]

Major glitch in front facing UI.

Comment 4

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Peter, does this require a platform fix or a system app fix?

Comment 5

[Peter Chang[:pchang]]

This should be fixed by bug 1098161.

Comment 6

[Peter Chang[:pchang]]

(In reply to peter chang[:pchang][:peter] from comment #5)
> This should be fixed by bug 1098161.

Oops...looks like this issue is still existed after bug 1098161. And gecko detects this element contains text. What are the difference between this rocketbar on homescreen and another rocketbar with keyboard? (after you click rocketbar, start to type something)

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to peter chang[:pchang][:peter] from comment #6)
> Oops...looks like this issue is still existed after bug 1098161. And gecko
> detects this element contains text. What are the difference between this
> rocketbar on homescreen and another rocketbar with keyboard? (after you
> click rocketbar, start to type something)

The actual rocket bar being typed is an <input type=search> in the System app. I don't know the hit area in Home screen app is and it is very likely it's just a button.

Anyway, you can use DevTools inspector to find out.

Comment 8

[Peter Chang[:pchang]]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #7)
> (In reply to peter chang[:pchang][:peter] from comment #6)
> > Oops...looks like this issue is still existed after bug 1098161. And gecko
> > detects this element contains text. What are the difference between this
> > rocketbar on homescreen and another rocketbar with keyboard? (after you
> > click rocketbar, start to type something)
> 
> The actual rocket bar being typed is an <input type=search> in the System
> app. I don't know the hit area in Home screen app is and it is very likely
> it's just a button.
> 
> Anyway, you can use DevTools inspector to find out.

If so, we should add select:none for this area in home screen app. Does it already include in gaia homescreen app?

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Kevin, could you confirm?

Comment 10

[GitHub Autolander Bot]

Attachment: [PullReq] KevinGrandon:bug_1112473_home_screen_user_select to mozilla-b2g:master

Comment 11

[Kevin Grandon :kgrandon]

Comment on attachment 8539049 [details] [review]
[PullReq] KevinGrandon:bug_1112473_home_screen_user_select to mozilla-b2g:master

This seems to work for me. I was unable to use select: none though, as it says that CSS selector is not supported on master. Other apps seem to use -moz-user-select, and using that here works.

Peter - I'm not sure who knows the select CSS stuff well, but since you gave a suggestion, would you be willing to put a review stamp on this? Thanks!

Comment 12

[Peter Chang[:pchang]]

Comment on attachment 8539049 [details] [review]
[PullReq] KevinGrandon:bug_1112473_home_screen_user_select to mozilla-b2g:master

Looks good to me but I don't know who in gaia should review this patch. Chris, could you help to review?

Comment 13

[Kevin Grandon :kgrandon]

In master: https://github.com/mozilla-b2g/gaia/commit/4cac716e425f877e3f31a5c1769cbcec40a0097f

Comment 14

[Gerry Chang [:gchang]]

Verified @ 
Gaia-Rev        ab41c35eed35404b632a4841714b81b56364ba32
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/2acb12da9813
Build-ID        20141224160204
Version         37.0a1
Device-Name     flame
FW-Release      4.4.2