1113365 - Add Afrikaans Keyboard layout and Dictionary

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Delphine Lebédel [:delphine - Use needinfo]]

Afrikaans will need specific keyboard layout support

Comment 1

[Delphine Lebédel [:delphine - Use needinfo]]

[Blocking Requested - why for this release]:
Afrikaans (af) shipping on 2.0 and onwards. We will need keyboard for 2.0 and onward branches

Comment 2

[Wesly Huang (EPM)]

[Blocking Requested - why for this release]:

[Triage] Considering current 2.0 timing and the need from partner, nom. to 2.1 (or even 2.2?) instead for consideration.

Comment 3

[Friedel Wolff]

This is quite easy to do. We have a few choices:

- From quick testing, only this character is missing: ý (y with acute accent). If we can just add it to the list of diacritics for the letter y in the current layout, nothing else would be needed.

- We can make a separate layout based on en-US with the necessary changes. The advantage is that we can simplify a bit by removing some of the characters that are not necessary.

- We can consider making a layout for South Africa containing everything that is required for all official languages. Although not all languages are targeted for UI localisation, it would be wonderful if people can at least type all characters. This way people can select this layout even if they are not using a UI localisation specifically for their language (because it is not available or because of preference).

They are probably sorted in order of increasing difficulty. None of these are very difficult in principle, though, except maybe selecting a "South African" layout from a few different locales.

Can somebody point me to the right repositories, branches and the right places to get going to try to do this? Or can I merely supply the data to someone?

Comment 4

[Delphine Lebédel [:delphine - Use needinfo]]

Thanks for your input Friedel, it's very helpful.
Concerning the version we need this on, we will get more update on that during the week. I will change the flags if needed in the bug so you know.
Keyboards for 2.0 are here for example: https://github.com/mozilla-b2g/gaia/tree/v2.0/apps/keyboard/js/layouts

I'll let keyboard team explain better for the process here. thanks!

Comment 5

[Friedel Wolff]

Attachment: Pull request for basic Afrikaans input

This pull request implements a keyboard layout and basic dictionary for Afrikaans input on Gaia. I'm not sure what the dependencies are between these, so I put them together in one pull request.

I'd like to give it another day or so of testing before backporting to other branches, but I believe it is working reasonably well.

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8545215 [details] [review]
Pull request for basic Afrikaans input

Let's just dup the bug together and squash the commits under one bug number.

Friedel, your choice to pick the lucky bug :D

Comment 7

[Delphine Lebédel [:delphine - Use needinfo]]

[Blocking Requested - why for this release]:

As per our call with Bus Dev, Rel Man and l10n team this morning, it is confirmed that this is needed on 2.0 (and onwards). Thus renominating for 2.0 work

Comment 8

[Dwayne Bailey]

Nice work Friedel :)

I'd like to second option 3 in comment 3.  The ability to type in any of the 11 official South African languages would be a plus.  Afrikaans has by far the most additional diacritics the following languages Northern Sotho and Venda, add about 6 more if I recall correctly.

Comment 9

[David Palomino [:dpalomino]]

Hi, 

Do we have any ETA for this to be landed? This is a blocker for the launch, we'd need this by this Friday.

Thanks!
David

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Dwayne, Friedel,

Unfortunately this suddenly got bumped to v2.0. Would you be able to submit a new pull request by today? If not my team will take over.

(Adding myself to the mentor field so this bug is not lost.)

Comment 12

[Friedel Wolff]

I will submit what I have in a few hours.

Comment 13

[Friedel Wolff]

Attachment: Pull request for basic Afrikaans input (v2.0)

This pull request implements a keyboard layout and basic dictionary for Afrikaans input on Gaia. It is based on the work shown before in pull request 27196, but first backported to 2.0, since that is urgent. Based on testing and feedback, the dictionary is expanded, and the layout is simplified based on font bugs which doesn't look like they'll be fixed in time for 2.0.

It is mostly based on the English layout in master (not 2.0), with some of the features of the 2.0 English layout adopted for greater consistency.

If this is fine, I'll try to forward port as required.

I don't know which other magic flags I need to set. I hope someone can guide me through the rest of the process.

Comment 14

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8553307 [details] [review]
Pull request for basic Afrikaans input (v2.0)

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): feature
[User impact] if declined: No Afrikaans layout nor dictionary
[Testing completed]: manually by patch author
[Risk to taking this patch] (and alternatives if risky): 
Layout is not build by default unless explicitly set in v2.0
[String changes made]: None.

Comment 15

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Delphine, we were told this this super rush but there is no activity after the approval flag is set. Could you confirm if this is really the case? Maybe needinfo :bajaj to get her attention on approval?

Comment 16

[Delphine Lebédel [:delphine - Use needinfo]]

Flagging Bhavana for this. Thanks for the heads-up

Comment 17

[Delphine Lebédel [:delphine - Use needinfo]]

changing title to reflect that with this bug will land both layout + dictionary

Comment 18

[Delphine Lebédel [:delphine - Use needinfo]]

David Palomino let us know that partner needs this by this Friday at the very latest.
This got the approval for 2.0 last week. Can we please get this landed on 2.0 before Friday please?

Comment 19

[Tim Guan-tin Chien [:timdream] (please needinfo)]

You don't need me to land code... :)

Comment 20

[Delphine Lebédel [:delphine - Use needinfo]]

ok didn't know if it was good etiquette to just go ahead and ask for that although it's not my patch :P thanks for letting me know, will do next time!

Comment 21

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/ecb1bbc3b9c00f82df172427f65d6f67e34ed533

The patch for master needs rebasing. Also, do we need this on v2.1/v2.2 as well?

Comment 22

[Delphine Lebédel [:delphine - Use needinfo]]

Yes, we would need those there as well since there will surely be updates on phones, as well as other parnters coming in and taking that language

Comment 23

[Friedel Wolff]

Ryan: yes, we need it for all branches - I focussed on 2.0 due to the urgent requirements for launch. Can anybody summarise (or point to a summary of) the changes required for each branch? If not, which layout is the best example to work from? I just know that things looked different between master and 2.0 when I started.

I'm not sure when I'll have time to work on this. I've spent a tonne of time on launch related things, and there are lots left for marketing, etc. so I'm not available soon to work on this.

Comment 24

[David Palomino [:dpalomino]]

(In reply to Friedel Wolff from comment #23)
> Ryan: yes, we need it for all branches - I focussed on 2.0 due to the urgent
> requirements for launch. Can anybody summarise (or point to a summary of)
> the changes required for each branch? If not, which layout is the best
> example to work from? I just know that things looked different between
> master and 2.0 when I started.
> 
> I'm not sure when I'll have time to work on this. I've spent a tonne of time
> on launch related things, and there are lots left for marketing, etc. so I'm
> not available soon to work on this.

Thanks a lot Friedel for the effort. 2.0 is definitely our focus. The absolute last cut-off date for this is Feb 18th, then the vendor will get the 2.0 branch to generate their build. 

Please, let us know if it's possible to fulfill this date. 

Thanks!
David

Comment 25

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to David Palomino [:dpalomino] from comment #24)
> Thanks a lot Friedel for the effort. 2.0 is definitely our focus. The
> absolute last cut-off date for this is Feb 18th, then the vendor will get
> the 2.0 branch to generate their build. 
> 
> Please, let us know if it's possible to fulfill this date. 
> 
> Thanks!
> David

The patch has already landed on v2.0 -- Friedel is talking about his availability to master branch.

Or, Rudy, could you land the patches for Friedel instead? For master/v2.2/v2.1.

Comment 26

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Yeah, sure, I'll try to create each branch-specific pull request for this layout support.
Keep the ni as is so that this will be in my queue.

Comment 27

[David Palomino [:dpalomino]]

> The patch has already landed on v2.0 -- Friedel is talking about his
> availability to master branch.

Ok, thanks for the clarification. And thanks to all for the effort! We'll have a great l10n in South Africa!

David

Comment 28

[GitHub Autolander Bot]

Attachment: [gaia] RudyLu:keyboard/Bug1113365-Afrikaans_Keyboard_master > mozilla-b2g:master

Comment 29

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8565339 [details] [review]
[gaia] RudyLu:keyboard/Bug1113365-Afrikaans_Keyboard_master > mozilla-b2g:master

This is the patch for master branch, and all tests passed.

Tim, could you please help review this?
Thank you.

Comment 30

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Landed to Gaia master,
https://github.com/mozilla-b2g/gaia/commit/2f33ab625b863410532c55341039ffc420796403

Comment 31

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8565339 [details] [review]
[gaia] RudyLu:keyboard/Bug1113365-Afrikaans_Keyboard_master > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined:
[Testing completed]:
[Risk to taking this patch] (and alternatives if risky):
[String changes made]:

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Feature, based on comment 14 & comment 23.
[User impact] if declined: No Afrikaans layout nor dictionary.
[Testing completed]: Manually by patch author
[Risk to taking this patch] (and alternatives if risky): Low since this layout won't be built by default unless explicitly set for each branch.
[String changes made]: N/A.

Comment 32

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Please don't uplift to v2.1 since we would need a branch-specific patch for that.
Thanks.

Comment 33

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Attachment: PR for v2.2

Comment 34

[GitHub Autolander Bot]

Attachment: [gaia] RudyLu:keyboard/Bug1113365-Afrikaans_keyboard_v2.2 > mozilla-b2g:v2.2

Comment 35

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/ecc36e24d3d65f9b1be9fea2f050c025d0ed2cc0

Comment 36

[GitHub Autolander Bot]

Attachment: [gaia] RudyLu:keyboard/Bug1113365-Afrikaans_keyboard_v2.1 > mozilla-b2g:v2.1

Comment 37

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8571735 [details] [review]
[gaia] RudyLu:keyboard/Bug1113365-Afrikaans_keyboard_v2.1 > mozilla-b2g:v2.1

pull request for v2.1.

Comment 38

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/f8ad1685e08e8da08badfe76c3a0044f08f66f4b