1113953 - Bug 1097754 Follow up - Centralizing the default Plivo timeout value

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[William Hsu [:whsu]]

Plivo timeout value is recorded in different test case.
We need to evaluate it to see if it worth to centralize the default timeout value.
1. Pros
2. Cons
3. How to...

Comment 1

[William Hsu [:whsu]]

Accident...

Comment 2

[Johan Lorenzo [:jlorenzo]]

Bug 1097754 hasn't landed yet. Let's drop this current issue until the dependency is resolved.

Comment 3

[Johan Lorenzo [:jlorenzo]]

Attachment: Gaia PR

Kicked off DSDS job: http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/558
Non-DSDS job: http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/557

The non DSDS job has 3 errors, which are likely due to bug 1097754 and bug 1118728

Comment 4

[Johan Lorenzo [:jlorenzo]]

Bug 1097754 is not about timeouts anymore.

Comment 5

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Comments in github. TL;DF: should use timeout= syntax instead of reverting to positional, and I optionally suggest wait_for_call_completed/connected() wrappers in PlivoUtil since it's obviously a common construct.

Comment 6

[Johan Lorenzo [:jlorenzo]]

I agree with both of your points. I updated the PR. I left 2 new commits to make the second review easier (I'll squash them before the merge). The tests look way better that way.

Comment 7

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Comment on attachment 8545272 [details] [review]
Gaia PR

Looks great!

Comment 8

[Johan Lorenzo [:jlorenzo]]

Kicked off new jobs after the update PR in comment 6.
DSDS: http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/570/
Non-DSDS: http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/571/

Comment 9

[William Hsu [:whsu]]

Comment on attachment 8545272 [details] [review]
Gaia PR

Great!

The patch looks good to me!
Diff this change, PLIVO_TIMEOUT was used 25 times in original tests, Johan successfully centralizes PLIVO_TIMEOUT value and reduce many function calls.


The results also looks good to me.
@ DSDS: http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/570/
  - Result: 4 passed: 4 and 0 failed

@ Non-DSDS: http://jenkins1.qa.scl3.mozilla.com/view/UI/job/flame-kk.ui.adhoc/571/
  - 13 passed and 2 failed (The 2 fail case doesn't relate to the patch)

Thanks Johan! r+
Have a nice weekend! :)

Comment 10

[Florin Strugariu [:Bebe]]

https://github.com/mozilla-b2g/gaia/commit/8c1ad7f5698cdf8f95732d7b38d8c497c0b8ffbf