11142 - [PP] saving wallet info hangs apprunner

Status: VERIFIED FIXED

(Core :: Networking, defect, P3)

Description

[Jay Patel [:jay]]

if you fill out the form to save your wallet info and then click "SAVE" at the
bottom, the confirmation dialog begins to pop up, but apprunner hangs in the
process and you have to force quit apprunner.  also, if you go to the amazon
page and try to do edit | wallet | safe form fill, apprunner hangs too.

machine and build:
MacOS 8.5.1 build 1999080212

Comment 1

[Stephen P. Morse]

Did this work in the last released bits for the non-necko version?

Comment 2

[Paul MacQuiddy]

Steve, saving wallet info was fine on the mac in the last non-necko builds of
7/28.

However, the Safe Form Fill has been messed up for a long time, bug 9773

Comment 3

[Stephen P. Morse]

In that case, could you please subdivide this into two bugs -- one for the save
and one for the safe form fill.  And assign the save bug to the necko team.

Comment 4

[Paul MacQuiddy]

The safeform fill bug is already filed, 9773. Re-assigning this one to necko
team. To reproduce (only on Mac).

Warren, this is a mac only problem that occurred when necko was turned on. To
reproduce:

1. Launch Mac Client
2. Edit - Samples - Amazon
3. Enter Mozilla in the Name Field
4. Hit Done at the bottom
5. You will get a dialogue asking if you want to save, Press Yes

This will hang the client on the Mac.

Comment 5

[Warren Harris]

Gordon...

Comment 6

[leger]

paulmac...Mca only?

Comment 7

[Paul MacQuiddy]

yes, mac only, adding the dreaded PP

Comment 8

[Stephen P. Morse]

I just noticed that NetSupportPassword.xul was missing from the
xpfe/browser/resources/content/Manifest file.  This would definitely account for
this bug because in the cases cites here the wallet code is attempting to open
the xul file that prompts the user for is password.  I'll be testing this out
today and if it the fix works, will be checking it in and closing out this
report.

Comment 9

[Stephen P. Morse]

I don't understand how this could ever have worked pre-necko.  Maybe it was just
a coincidence that this started happening at the same time that necko was
enabled.

Comment 10

[Andreas Otte]

Remember that the workaround for sync http load and saving as file is not
working on the mac. This is also called when calling save form fill. The mac
version is spinning in an loop but not getting and dispatching events, thus
never breaking the loop. I asked gordon for a reference implementation in one of
the necko testprograms ...

Comment 11

[Stephen P. Morse]

OK that makes sense.  And we put in that work-around on 8-1 and this bug was
reported on 8-2.  So it is a necko thing.  And the fact that I found this error
in the Manifest file was unrelated but would have been the next thing to block
wallet from working on the mac.

So should this bug be marked as a dup of 10456?

Comment 12

[Jay Patel [:jay]]

This is no longer happening with Mac build 1999081009...resolving fixed.  Paul,
can you confirm this and verify it fixed?

Comment 13

[Stephen P. Morse]

Sure it's fixed.  As of last night I disabled the mac from downloading the
mapping tables because of this problem.  So it no longer manifests itself as
described here.  But, instead, we have the problem described in bug 11540.

Comment 14

[Paul MacQuiddy]

what steve said

Comment 15

[leger]

Bulk move of all Necko (to be deleted component) bugs to new Networking

component.