UiTour: loop.gettingStarted.url is missing a trailing slash?

RESOLVED FIXED in Firefox 35

Status

()

Firefox
Tours
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: agibson, Assigned: MattN)

Tracking

37 Branch
Firefox 37
Points:
1
Bug Flags:
firefox-backlog +
in-testsuite -
qe-verify -

Firefox Tracking Flags

(firefox35 fixed, firefox36 fixed, firefox37 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

3 years ago
Looks like the default value for `loop.gettingStarted.url` is missing a trailing slash '/' at the end:

`https://www.mozilla.org/%LOCALE%/firefox/%VERSION%/hello/start`

I think (?) this could result in the FTE opening a new tab every time the conversation connects, as bedrock will append a trailing slash when the page opens like e.g.

https://www-demo2.allizom.org/en-US/firefox/37.0a1/hello/start/?utm_source=firefox-browser&utm_medium=firefox-browser&utm_campaign=settings-menu

When testing locally this missing trailing slash was the reason one of my machines was opening a new tab every time, while the other was not. But then I noticed the default value in Firefox is also omitting a slash.
(Reporter)

Updated

3 years ago
Blocks: 1080942
# History

This was determined here: https://bugzilla.mozilla.org/show_bug.cgi?id=1099462#c3

I'll also mention that we'll need to double-check the Tour link from the Gears menu.

+ :jaws as he worked on the original bug.
Going to fix and try uplift to Beta today.
Assignee: nobody → MattN+bmo
Status: NEW → ASSIGNED
Iteration: --- → 37.2
Points: --- → 1
status-firefox35: --- → affected
status-firefox36: --- → affected
status-firefox37: --- → affected
Flags: qe-verify-
Flags: firefox-backlog+
Hardware: x86 → All
Created attachment 8540219 [details]
MozReview Request: bz://1114486/MattN
Attachment #8540219 - Flags: review?(jaws)
/r/1625 - Bug 1114486 - Add a trailing slash to loop.gettingStarted.url so switchToTab works properly with the redirect adding the slash. r=jaws

Pull down this commit:

hg pull review -r 92c5974cabe078f8d12b29605e7293d360a3adc7
For more context, we need the URL path to match for switchToTab.
Attachment #8540219 - Flags: review?(jaws) → review+
https://reviewboard.mozilla.org/r/1623/#review1035

Ship It!
https://hg.mozilla.org/integration/fx-team/rev/5c5ae97511db
Flags: in-testsuite-
Whiteboard: [fixed-in-fx-team]
status-firefox37: affected → fixed
https://hg.mozilla.org/mozilla-central/rev/5c5ae97511db
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 37
Comment on attachment 8540219 [details]
MozReview Request: bz://1114486/MattN

Approval Request Comment
[Feature/regressing bug #]: Bug 1099462
[User impact if declined]: If the URL in-product doesn't match the existing tab URL, multiple tabs may end up getting opened instead of re-using the tour tab.
[Describe test coverage new/current, TBPL]: QE will test the tour before release
[Risks and why]: Low risk one-character change adding a "/"
[String/UUID change made/needed]: None
Attachment #8540219 - Flags: approval-mozilla-beta?
Attachment #8540219 - Flags: approval-mozilla-aurora?
Attachment #8540219 - Flags: approval-mozilla-beta?
Attachment #8540219 - Flags: approval-mozilla-beta+
Attachment #8540219 - Flags: approval-mozilla-aurora?
Attachment #8540219 - Flags: approval-mozilla-aurora+
Thanks Gavin.

https://hg.mozilla.org/releases/mozilla-aurora/rev/c2fe047664b6
https://hg.mozilla.org/releases/mozilla-beta/rev/fc0c24702973
status-firefox35: affected → fixed
status-firefox36: affected → fixed
Comment on attachment 8540219 [details]
MozReview Request: bz://1114486/MattN
Attachment #8540219 - Attachment is obsolete: true
Attachment #8618944 - Flags: review+
Created attachment 8618944 [details]
MozReview Request: Bug 1114486 - Add a trailing slash to loop.gettingStarted.url so switchToTab works properly with the redirect adding the slash. r=jaws
You need to log in before you can comment on or make changes to this bug.