Closed Bug 1115009 Opened 7 years ago Closed 1 month ago
Remove useless focus calls from search
.xml now that the search popup doesn't disappear and reappear when searching in a separate tab
In bug 1106101, the popup is getting closed by the "w.gBrowser.selectedBrowser.focus();" call at http://mxr.mozilla.org/mozilla-central/source/browser/base/content/utilityOverlay.js#349 and that seems like the wrong behaviour, but given the timelines, I felt it was better to live with the close-and-reopen than to try hacking around in openLinkIn… Having said that, we should definitely look into fixing/changing that behaviour, or figuring out why it needs to act that way.
I'm only doing this to describe the real state of affairs (to prevent any confusion). Please revert my changes if this is not a regression and if this was not caused by bug 1106101.
I think bug 1313403 will fix this. When that's landed and has stuck, we should remove some of the workaround-y this.focus() calls in search.xml, which should now be no-ops.
Depends on: 1313403
Is this bug Fixed after it was improved in bug 1313403, then worsened in bug 1316863?
Testing on Nightly on Windows 10, it looks fixed to me…
(In reply to arni2033 [Please stop 'improving' Firefox] from comment #5) > Is this bug Fixed after it was improved in bug 1313403, then worsened in bug > 1316863? See comment #4. Among others, https://dxr.mozilla.org/mozilla-central/rev/c91249f41e3766274131a84f9157a4d9d9949520/browser/components/search/content/search.xml#409-410 looks like it should be removed. Also, https://dxr.mozilla.org/mozilla-central/rev/c91249f41e3766274131a84f9157a4d9d9949520/browser/components/search/content/search.xml#479-480 look like they should be removed but we might need to add markup to the panel to avoid it closing in that specific case (adding a search engine) which I haven't tested.
Summary: Search box disappears and reappears when Cmd-clicking an item (Perhaps don't focus the selectedBrowser when opening a background tab?) → Remove useless focus calls from search.xml now that the search popup doesn't disappear and reappear when searching in a separate tab
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.