1115018 - On startup, error "Windows cannot find ... uninstall\helper.exe"

Status: RESOLVED FIXED

(Thunderbird :: Installer, defect)

Description

[Wayne Mery (:wsmwk)]

I updated to 2014-12-23 nightly from 2014-10-29 using custom installer. 
https://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/2014-12-23-03-02-00-comm-central/thunderbird-37.0a1.en-US.win32.installer.exe

On startup I get error dialog with
 Windows cannot find ... uninstall\helper.exe

uninstall\helper.exe is indeed missing from the uninstall directory

Comment 1

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

I updated yesterday with the built-in installer and after launching Daily today, I get this error.

Updated yesterday to 20141226030201.
Used 20141219030203 before.

Comment 2

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

"uninstall" folder exists in Daily 20141221 but not in 20141222

Likely a regression from c-c bug 741340 (Allow crosscompiling for Windows without NSIS)

Pushlogs:
mozilla-central: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=7b33ee7fd162&tochange=b915a50bc6be
comm-central: http://hg.mozilla.org/comm-central/pushloghtml?fromchange=7bc453bb4cdd&tochange=8d3f8239c7b7

Comment 3

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

Attachment: patch, v1

Do it like Firefox: Use XP_WIN32: http://hg.mozilla.org/mozilla-central/file/67c42c076393/browser/installer/package-manifest.in#l57

Comment 4

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

Attachment: patch, v2, r=clokep, jcranmer

Comment 5

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/284ea3b98840