1115601 - Wrong resource uri generated when running on sdk master with -o

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Sample code:

console.log(">>", require('sdk/self').data.url('something'));

If I run using jpm -b nightly run:

resource://data-uri-bug/data/something

If I run using jpm -o ~/code/jetpack/addon-sdk/ though, I get:

resource://data-uri-bug/data-uri-bug/data/something

..this breaks icons in buttons, etc. Not completely sure why it's happening, only happens against current master.

resource://data-uri-bug/data-uri-bug/data/something

Comment 1

[Jeff Griffiths (:canuckistani) (:⚡︎)]

More on this, the guilty party seems to be:

https://github.com/mozilla/addon-sdk/commit/dddcc2ac118b78c2aa560799b78264587033cecc#diff-4f5345f90b44fd35f6563db4ff549253R24

options.prefixURI always seems to be

It doesn't make any sense for use to add options.name to the end of prefixURI? I can fix this by changing 

https://github.com/mozilla/addon-sdk/blob/master/lib/sdk/self.js#L24

from 

const baseURI = ("prefixURI" in options) ? (options.prefixURI + (name ? (name + "/") : "")) : readPref("baseURI");

to 

const baseURI = ("prefixURI" in options) ? options.prefixURI : readPref("baseURI");

I've opened this PR:

https://github.com/mozilla/addon-sdk/pull/1772

Comment 2

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Irakli, Erik - are there recent changes in the loader that would cause this? Does my fix make sense?

Comment 3

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to Jeff Griffiths (:canuckistani) from comment #2)
> Irakli, Erik - are there recent changes in the loader that would cause this?
> Does my fix make sense?

I think this make break under cfx, also it is failing on travis.

I'm not sure what the right thing to do here is yet, we should take a closer look at this before uplift I think though.

Comment 4

[Jeff Griffiths (:canuckistani) (:⚡︎)]

In my tests my fix didn't break cfx. YMMV.

Comment 5

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1806

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/62e206d79a2de3b00dc9fa8bc6625ca2f0df719e
Bug 1115601 - Wrong resource uri generated when running on sdk master with -o

reverting this line change https://github.com/mozilla/addon-sdk/commit/dddcc2ac118b78c2aa560799b78264587033cecc#diff-4f5345f90b44fd35f6563db4ff549253R24

https://github.com/mozilla/addon-sdk/commit/aeac541419406bf9b38f1dbaa6adbd4e94058aae
Merge pull request #1806 from erikvold/1115601

Bug 1115601 - Wrong resource uri generated when running on sdk master with -o a=me

Comment 7

[Erik Vold [:erikvold] (please needinfo? me)]

removing the ni for Irakli.