Closed Bug 1115633 Opened 7 years ago Closed 7 years ago

[Stingray] Behavior after unpin app in App-Deck is inconsistent with other deck

Categories

(Firefox OS Graveyard :: Gaia, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dwi2, Assigned: dwi2)

References

Details

(Whiteboard: [ft:conndevices][ETA:1/16])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
rexboy
: review+
Details | Review
UX spec of Application Deck did not specify behavior after unpin. But UX spec of TV Deck specifies that after unpin, we should stay at the screen before unpin. I guess all unpin behavior should be the same.
Depends on: 1111466
A proper way is probably to use IAC instead of activity to make app unpin from home.
Assignee: nobody → tzhuang
Status: NEW → ASSIGNED
Blocks: 1074079
No longer blocks: CardUI-Followup
Whiteboard: [ft:conndevices] → [ft:conndevices][ETA:1/16]
See Also: → 1118143
Attached file pull request
Hi Rex, 

Could you help to review the patch? Thanks

We establish an IAC, which is from app-deck to smart-home, to send unpin message in this patch. And app uninstalling is also implemented in this patch. Note that we have not apply visual to confirm dialog of app install/uninstall yet. That will be fixed in bug 1120357.
Attachment #8547952 - Flags: review?(rexboy)
I have some questions on this bug. Let's discuss tomorrow. Let me hold my r+ until then.
Comment addressed. Please help to review it again. Thanks
Comment on attachment 8547952 [details] [review]
pull request

r=me
Attachment #8547952 - Flags: review?(rexboy) → review+
Gaia-try is green
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=c2447081b5f7

Landed on master
https://github.com/mozilla-b2g/gaia/commit/6ac94c72a187192dbb9af579c2aa6f2390623fc3
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.