1115633 - [Stingray] Behavior after unpin app in App-Deck is inconsistent with other deck

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Tzu-Lin Huang [:dwi2][:tzhuang]]

UX spec of Application Deck did not specify behavior after unpin. But UX spec of TV Deck specifies that after unpin, we should stay at the screen before unpin. I guess all unpin behavior should be the same.

Comment 1

[Tzu-Lin Huang [:dwi2][:tzhuang]]

A proper way is probably to use IAC instead of activity to make app unpin from home.

Comment 2

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Attachment: pull request

Hi Rex, 

Could you help to review the patch? Thanks

We establish an IAC, which is from app-deck to smart-home, to send unpin message in this patch. And app uninstalling is also implemented in this patch. Note that we have not apply visual to confirm dialog of app install/uninstall yet. That will be fixed in bug 1120357.

Comment 3

[KM Lee [:rexboy] (inactivate after Sep. 22)]

I have some questions on this bug. Let's discuss tomorrow. Let me hold my r+ until then.

Comment 4

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Comment addressed. Please help to review it again. Thanks

Comment 5

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8547952 [details] [review]
pull request

r=me

Comment 6

[Tzu-Lin Huang [:dwi2][:tzhuang]]

Gaia-try is green
https://treeherder.mozilla.org/ui/#/jobs?repo=gaia-try&revision=c2447081b5f7

Landed on master
https://github.com/mozilla-b2g/gaia/commit/6ac94c72a187192dbb9af579c2aa6f2390623fc3