Closed Bug 1116223 Opened 5 years ago Closed 4 years ago

The chrome.manifest for the default theme is not packaged any more

Categories

(Thunderbird :: Build Config, defect, trivial)

defect
Not set
trivial

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 49.0

People

(Reporter: Nomis101, Assigned: philip.chee)

References

Details

Attachments

(1 file)

In Bug 654672 a fake chrome.manifest was added to suppress the "Could not read chrome manifest" message. If I look into all current Thunderbird builds, this file is not included anymore. Nothing from Bug 654672 was removed, so I don't know why the file is not included anymore. But as a result of that you again see in the error console:

Could not read chrome manifest 'file:///Volumes/Daily/Daily.app/Contents/Resources/extensions/%7B972ce4c6-7e08-4474-a285-3208198ce6fd%7D/chrome.manifest'.
Also seen on Windows.
OS: Mac OS X → All
Hardware: x86 → All
ff has @BINPATH@/browser/chrome.manifest
http://mxr.mozilla.org/comm-central/source/mozilla/browser/installer/package-manifest.in#651

.. and tb have
@RESPATH@/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}/chrome.manifest

... which tb does not have. Maybe that's the difference that need fixing?
See Also: → 586610, 808361
Summary: Chrome.manifest is not included anymore → The chrome.manifest for the default theme is not packaged any more
References:
Bug 1022354 Move override for defaultFavicon from content to classic skin now that Bug 1170207 is fixed.

Bug 1170207 - Themes should be allowed to override things in chrome skin packages with other things in chrome skin packages

Bug 1150417 - Move default theme aero/XP overrides into separate chrome.manifest so it doesn't break custom themes
Assignee: nobody → philip.chee
Status: NEW → ASSIGNED
Attachment #8755139 - Flags: review?(mkmelin+mozilla)
Comment on attachment 8755139 [details] [diff] [review]
Move skin overrides to the chrome.manifest in the default theme XPI

Review of attachment 8755139 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good afaikt. r=mkmelin
Attachment #8755139 - Flags: review?(mkmelin+mozilla) → review+
http://hg.mozilla.org/comm-central/rev/eac6743dc58b
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 49.0
You need to log in before you can comment on or make changes to this bug.