1116223 - The chrome.manifest for the default theme is not packaged any more

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Nomis101]

In Bug 654672 a fake chrome.manifest was added to suppress the "Could not read chrome manifest" message. If I look into all current Thunderbird builds, this file is not included anymore. Nothing from Bug 654672 was removed, so I don't know why the file is not included anymore. But as a result of that you again see in the error console:

Could not read chrome manifest 'file:///Volumes/Daily/Daily.app/Contents/Resources/extensions/%7B972ce4c6-7e08-4474-a285-3208198ce6fd%7D/chrome.manifest'.

Comment 1

[rsx11m]

Also seen on Windows.

Comment 2

[Magnus Melin [:mkmelin]]

ff has @BINPATH@/browser/chrome.manifest
http://mxr.mozilla.org/comm-central/source/mozilla/browser/installer/package-manifest.in#651

.. and tb have
@RESPATH@/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}/chrome.manifest

... which tb does not have. Maybe that's the difference that need fixing?

Comment 3

[Philip Chee]

Attachment: Move skin overrides to the chrome.manifest in the default theme XPI

References:
Bug 1022354 Move override for defaultFavicon from content to classic skin now that Bug 1170207 is fixed.

Bug 1170207 - Themes should be allowed to override things in chrome skin packages with other things in chrome skin packages

Bug 1150417 - Move default theme aero/XP overrides into separate chrome.manifest so it doesn't break custom themes

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 8755139 [details] [diff] [review]
Move skin overrides to the chrome.manifest in the default theme XPI

Review of attachment 8755139 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good afaikt. r=mkmelin

Comment 5

[Philip Chee]

http://hg.mozilla.org/comm-central/rev/eac6743dc58b