654672 - Could not read extensions chrome manifest file (972ce4c6-7e08-4474-a285-3208198ce6fd = default theme)

Status: VERIFIED FIXED

(Thunderbird :: Build Config, defect)

Description

[Mark Banner (:standard8)]

+++ This bug was initially created as a clone of Bug #586610 +++

Since the changes from Bug 579178, I see the following message in TBs error console:

Could not read chrome manifest file '/Volumes/Shredder/Shredder.app/Contents/MacOS/extensions/{972ce4c6-7e08-4474-a285-3208198ce6fd}/chrome.manifest'.

This extensions is the Thunderbird default theme.

Comment 1

[Mark Banner (:standard8)]

Attachment: Workaround

This is Nomis' patch that I'm moving from bug 586610. It looks fine and has r=me.

Comment 2

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/a4a2d352aa47

Comment 3

[Mark Banner (:standard8)]

I had to back this out because it busted the universal mac builds even after they were clobbered:

http://hg.mozilla.org/try-comm-central/rev/30c37ed6e0bb

I'm currently confused why that is the case though as I don't see anything wrong.

Comment 4

[Nomis101]

I'm also confused. If you or anybody else don't have an idea, I will try to investigate this.

Seems unify doesn't work. Line 517 of /unify is about lines of a file and newlines. Maybe it will work if the empty chrome.manifest contains a newline?

Comment 5

[Nomis101]

Attachment: New patch that (hopefully) works

OK, I was able to reproduce this with an UB build. This new patch works for me. 
Can someone please test this on try, I don't want to break comm-central again...

Comment 6

[Ludovic Hirlimann [:Usul]]

Pushed http://tbpl.mozilla.org/?tree=Try&rev=7c4e4b223575

Comment 7

[Ludovic Hirlimann [:Usul]]

(In reply to comment #6)
> Pushed http://tbpl.mozilla.org/?tree=Try&rev=7c4e4b223575
I meant http://build.mozillamessaging.com/tinderboxpushlog/?tree=ThunderbirdTry

Comment 8

[Ludovic Hirlimann [:Usul]]

Looks green to me.

Comment 9

[Nomis101]

Thanks for pushing to try :-) Do I need now review again for the working patch? I never before had an patch that was backed out...

Comment 10

[Ludovic Hirlimann [:Usul]]

Comment on attachment 530434 [details] [diff] [review]
New patch that (hopefully) works

(In reply to comment #9)
> Thanks for pushing to try :-) Do I need now review again for the working
> patch? I never before had an patch that was backed out...

yes it's a new patch and thus needs review.

Comment 11

[Mark Banner (:standard8)]

Comment on attachment 530434 [details] [diff] [review]
New patch that (hopefully) works

Thanks, that seems better. Checked in:

http://hg.mozilla.org/comm-central/rev/11953f14423a

Comment 12

[Mark Banner (:standard8)]

It stuck this time :-)

Comment 13

[rsx11m]

V. fixed, Windows 7 nightly (warning is present in 20110505 but not 20110506).