1116915 - Consider drawing the ActionBar action mode background rather than using assets

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Save space! Be more flexible! All around greatness!

You probably should figure out why we used a nine pach in the first place - maybe there's a good reason for it.

The code to set the background is here: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/resources/values-v11/styles.xml?rev=7be62fa11c20#80

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Mentorable?

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Questionably desirable: this might allow us to use LWT on the ActionBar action mode.

Comment 3

[Wesley Johnston (:wesj)]

We do the same thing Android does (in fact, we stole the image from thme). Is there a good reason not to use one? Blitting bitmaps is probably the fastest drawing method there is.

I would really like to replace our entire actionbar with a  	android.support.v7.widget.Toolbar and then delete all of our backwards compat support code at some point.

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Wesley Johnston (:wesj) from comment #3)
> We do the same thing Android does (in fact, we stole the image from thme).
> Is there a good reason not to use one? Blitting bitmaps is probably the
> fastest drawing method there is.

I don't think we care about drawing speed here because it's drawn once (besides the display animation) - I'm more concerned about the apk size.

> I would really like to replace our entire actionbar with a  
> android.support.v7.widget.Toolbar and then delete all of our backwards
> compat support code at some point.

File and/or link? Perhaps as "See also".

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Going to hold off on mentoring here because it's unclear whether this is desirable or not.

Comment 6

[Wesley Johnston (:wesj)]

The Toolbar compat code docs are at:

http://developer.android.com/reference/android/support/v7/widget/Toolbar.html

I think it would likely big a bigger project to do that but we could do it in piecies. i.e. Something like

1.) Import the library
2.) Use it
3.) Flip the actionbar to a toolbar
4.) Flip the actionmodes

i.e. I agree, its a "See also". I see the APK size argument now though. If you want, seems doable (although these images should be pretty tiny if they're properly drawn 9-patches).

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Wesley Johnston (:wesj) from comment #6)
> The Toolbar compat code docs are at:

Filed bug 1126061.

Comment 8

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.