1117329 - Clear needinfo flag when whiteboard is updated, or if editor opts to do so when submitting comment

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)

Description

[rctgamer3]

1. Request more information/testing credentials etc.
2. Developer adds testing information to the whiteboard
3. ?????
4. No notification is sent when the whiteboard has been updated by either the developer or a reviewer.

Result: The add-on may linger in the queue for a long time until someone tries to review the add-on and notices the developer replied to the request for more information by updating the whiteboard.

Comment 1

[Andreas Wagner [:TheOne] [use NI]]

Related to bug 1112372.

Comment 2

[Kris Maglione [:kmag]]

Reviewers should also be able to clear needinfo flag when adding comment.

Comment 3

[Mark Striemer [:mstriemer]]

Are there any other situations in which this flag should be cleared? Suggestions are reviewer adds a comment and has an option to clear (similar to bugzilla) and when the developer updates the whiteboard. What if the developer sets/changes their comment?

When this is cleared more frequently we should filter out need info reviews from non-admins as suggested in bug 1109299.

Comment 4

[Andreas Wagner [:TheOne] [use NI]]

NI should be cleared as well when

* 'Notes to reviewers' field changes
* New version is uploaded (we might already do that)
* Source package is uploaded (even if there already was an existing source package for that version) (we might already do that)

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/olympia

https://github.com/mozilla/olympia/commit/a61cb7f7c17e6f38c6d51faf5ecf9b0f62bbae6b
Clear has_info_request on whiteboard and developer_comments (bug 1117329)

https://github.com/mozilla/olympia/commit/a3416de8d62db41ca8d8a898d0477f26c9bd2c5f
Allow reviewers to clear info request when commenting (bug 1117329)

https://github.com/mozilla/olympia/commit/140f554486b98fc19ed0bb8ad7f8d1ed7f5b3ef6
Merge pull request #740 from mstriemer/clear-needinfo-1117329

Clear has_info_request on whiteboard and developer_comments (bug 1117329)