1118062 - [RTL][Email] The SSL values are aligned left on manual settings.

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::E-Mail, defect, P2)

Description

[Yeojin Chung [:YeojinC]]

Attachment: EmailManualSetup.png

Description:
On the Manual Setup page, the SSL number value is aligned left on the screen.
   
Repro Steps:
1) Update a Flame device to BuildID: 20150105010205.
2) Set the device language in Arabic under Settings > Language.
3) Open Email app.
4) Enter "Your name" and an email address, and select "Manual setup".
5) Observe the number value under "SSL".
  
Actual:
The number is left-aligned.
  
Expected: 
The number is right-aligned (the number still reads left to right).

Environmental Variables:
Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20150105010205
Gaia: 613550ddb8a7b96ed6bf2a39b0b2c7547e5dbf9a
Gecko: 636498d041b5
Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76
Version: 37.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
  
Repro frequency: 100%
See attached: screenshot

Comment 1

[Dylan Oliver [:doliver]]

RTL triage: P2 -- will make a best effort to get this into the 2.2 release.

Comment 2

[Dylan Oliver [:doliver]]

RTL update: marking required bugs as feature-b2g:2.2+ (and removing blocking flags)

Comment 3

[Norry.L.F(Leave from Mozilla)]

Test case has been added in moztrap:https://moztrap.mozilla.org/manage/case/15281/

Comment 4

[GitHub Autolander Bot]

Attachment: [PullReq] jrburke:bug1118062-email-ltr-text-left-aligned to mozilla-b2g:master

Comment 5

[James Burke [:jrburke]]

Comment on attachment 8562536 [details] [review]
[PullReq] jrburke:bug1118062-email-ltr-text-left-aligned to mozilla-b2g:master

This pull request removes a forcing of a left alignment for ltr text inside an input in a RTL UI. However, the text was explicitly added in this changeset:

https://github.com/mozilla-b2g/gaia/commit/c800d5d86c4d93b608f70165a59a0160398c0d89

For bug 1116803, so it may have side effects for that bug. 

Asking :Nefzaoui for feedback on if this is the correct fix. To my more RTL-newish eyes, I would not think we would want all text inputs with this forced left alignment for the reason demonstrated in this bug, it makes the ltr text, like a number, to show up out of place with the rest of the right-aligned UI.

Comment 6

[Stephany Wilkes]

Comment on attachment 8562536 [details] [review]
[PullReq] jrburke:bug1118062-email-ltr-text-left-aligned to mozilla-b2g:master

Setting feedback? to Kaze instead of Ahmed to spread the bug load a bit more evenly.

Comment 7

[Stephany Wilkes]

Comment on attachment 8562536 [details] [review]
[PullReq] jrburke:bug1118062-email-ltr-text-left-aligned to mozilla-b2g:master

It's Feature Landing day, calloo, callay. Reassigning this to Andrew since Kaze hasn't been able to take it.

Comment 8

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 8562536 [details] [review]
[PullReq] jrburke:bug1118062-email-ltr-text-left-aligned to mozilla-b2g:master

I lack review authority over anything in shared/.  Restoring existing feedback flag.

Comment 9

[James Burke [:jrburke]]

I'll likely just give this one other day, then just do style changes within the mail app to override the shared styles, if the shared styles are not sorted by then.

Comment 10

[James Burke [:jrburke]]

Comment on attachment 8562536 [details] [review]
[PullReq] jrburke:bug1118062-email-ltr-text-left-aligned to mozilla-b2g:master

This bug seems to be fixed on master now by the combination of bug 1126388 and bug 1115187 landing, which affected shared/style/input_areas.css. Bug 1126388 removed the problematic style mentioned in this pull request, and bug 1115187 is forcing those styles to be to the right now for inputs.

So closing as fixed, worksforme, and will be that way on 2.2 once bug 1126388 and bug 1115187 land there.