1118850 - The calendar icon in the bottom left hand corner doesn't always display the correct day of the month

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[Gareth Aye [:gaye] (back from PTO)]

Today is the 7th and it says "6". Tapping on it sends us (correctly) to the 7th in each of the views. This looks silly and will confuse users.

Comment 1

[Dylan Oliver [:doliver]]

tracking+ for the observed behavior but we're not sure exactly how to reproduce yet. Probably not a regression.

Comment 2

[Miller Medeiros [:millermedeiros]]

we definitely need a better abstraction to listen for days/minutes changes.. right now we use `setTimeout`.

also an opportunity to improve the performance of `calc.isToday()` (called many times during app startup) since we have a getter for `calc.today` which creates a new `Date` object on each call.

we should also update the "current time" on week/day views.

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] millermedeiros:1118850-day-minute-change > mozilla-b2g:master

Comment 5

[Gareth Aye [:gaye] (back from PTO)]

Started discussion on GH

Comment 6

[Gareth Aye [:gaye] (back from PTO)]

Comment on attachment 8593106 [details] [review]
[gaia] millermedeiros:1118850-day-minute-change > mozilla-b2g:master

One syntax nit on GH but otherwise r+. Thanks for rolling with the EventEmitter2 api.

Comment 7

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/57922c1d99a2a4663a561f896b1fdf33eab118c0