1119190 - [MMS] Icon for enclosed contacts

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Jose Manuel Cantera]

As a follow-up of bug 1007932 we need an specific icon for enclosed contacts in MMS messages. initial discussion happened on bug 1007932.

Comment 1

[Julien Wajsberg [:julienw] (PTO -> Mar 16)]

I guess this is a work for Fang :)

Comment 2

[Maria Angeles Oteo (:oteo)]

(In reply to Julien Wajsberg [:julienw] (PTO until 1/5) from comment #1)
> I guess this is a work for Fang :)

thanks Julien, she's already aware of it and Pau will provide the icon according to her feedback in bug 1007932 :)

Comment 3

[Pau Masiá [:Pau]]

Attachment: SMMS. Vcard icon 4

Here I attach a set of two new modified versions of the icon I've made taking into account Carol and Fang's suggestions.

I've removed the element of the hinge so we don't have detail loss issues in any device.

Which one of these versions do you prefer?

Thanks!

Comment 4

[Pau Masiá [:Pau]]

Attachment: SMMS. Vcard icon 5

Comment 5

[Julien Wajsberg [:julienw] (PTO -> Mar 16)]

I thess that the same icon be used for vcard attachments that we receive, just like other icons, right?

Comment 7

[Julien Wajsberg [:julienw] (PTO -> Mar 16)]

José, is there a meta bug for the vcard-in-MMS story? Can you please try to make all bugs depend on it so that it's easier to navigate? Thanks!

Comment 8

[Noemí Freire (:noemi)]

Nominating this for 2.2 since it is needed for Bug 1007932. Thanks!

Comment 9

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

triage: there's already existing icon for the function so this bug is UI enhancement.
Shouldn't be a blocker but would be great to submit patch for approval to uplift.

Comment 10

[Fang Shih [:fang]]

Attachment: SMMS_Vcard icon 5_v2.png

(In reply to Pau Masiá [:Pau] from comment #4)
> Created attachment 8548727 [details]
> SMMS. Vcard icon 5

Hi Pau, I think I prefer icon 5. Do you think we can move the cut off shape to the left upper side​, the angle looks more balance with the circle shape (contact head). I've updated the screen with slightly change icon. Let me know what you think, Thanks!

Comment 11

[Maria Angeles Oteo (:oteo)]

Setting ni to Pau, according to comment 10

Comment 12

[Pau Masiá [:Pau]]

(In reply to Fang Shih [:grasspizza] from comment #10)
> Created attachment 8551197 [details]
> SMMS_Vcard icon 5_v2.png
> 
> (In reply to Pau Masiá [:Pau] from comment #4)
> > Created attachment 8548727 [details]
> > SMMS. Vcard icon 5
> 
> Hi Pau, I think I prefer icon 5. Do you think we can move the cut off shape
> to the left upper side​, the angle looks more balance with the circle shape
> (contact head). I've updated the screen with slightly change icon. Let me
> know what you think, Thanks!

Sure I can, Fang! I think you're right. I'll update te icon and I'll export it to upload it here.
Thanks for the suggestion :)

Comment 13

[Pau Masiá [:Pau]]

Attachment: Vcard Icon

Hi, I attach here the icon in its four resolutions.
Thanks!

Comment 14

[Jose Manuel Cantera]

Noemi already updated the dependencies, so clearing ni here

Comment 15

[Jose Manuel Cantera]

Attachment: 2015-01-20-10-01-11.png

Comment 16

[Jose Manuel Cantera]

Attachment: 2015-01-20-10-00-27.png

Comment 17

[Jose Manuel Cantera]

Attachment: GH PR

modulo the UI review to be done by Fang, I think we are now ready to review the app code. thanks

Comment 18

[Steve Chung [:steveck]]

Comment on attachment 8551796 [details]
GH PR

Some concerns: 
 1) This contact icon looks way different from the origonal icon placeholder styling. I think Fang could reply this.
 2) Maybe use CSS sprit like other placeholer?
 3) There is other attachment might use ref type as well(like vCalendar). It seems not safe to apply contact icon to all the attachment with ref type.

Comment 19

[Jose Manuel Cantera]

(In reply to Steve Chung [:steveck] from comment #18)
> Comment on attachment 8551796 [details]
> GH PR
> 
> Some concerns: 
>  1) This contact icon looks way different from the origonal icon placeholder
> styling. I think Fang could reply this.
>  2) Maybe use CSS sprit like other placeholer?
>  3) There is other attachment might use ref type as well(like vCalendar). It
> seems not safe to apply contact icon to all the attachment with ref type.

Well I think these three questions are for Fang and Pau who were the persons in charge of the design. I have just crafted the design they have provided.

Comment 20

[Fang Shih [:fang]]

Comment on attachment 8551682 [details]
2015-01-20-10-01-11.png

Looks good! Thanks!

Comment 21

[Fang Shih [:fang]]

Comment on attachment 8551683 [details]
2015-01-20-10-00-27.png

I think we should be able to show the full name (vcf file name) here. I'll attach the mockup of this screen.

Comment 22

[Fang Shih [:fang]]

Attachment: SMS_MMS_vcard.png

Attached the vcard view in message bubble. 
Also for the icon. I think we don't need to make the vcard icon like the other media placeholders. They are originally a different type of info. Unlike media files. Thanks!

Comment 23

[Pau Masiá [:Pau]]

Clearing ni as Fang has already answered to this.

Comment 24

[Jose Manuel Cantera]

(In reply to Fang Shih [:grasspizza] from comment #22)
> Created attachment 8556254 [details]
> SMS_MMS_vcard.png
> 
> Attached the vcard view in message bubble. 
> Also for the icon. I think we don't need to make the vcard icon like the
> other media placeholders. They are originally a different type of info.
> Unlike media files. Thanks!

Hi Fang,

The proposed layout, although it is cool it would make the bubble sizes different depending on the type of attachment. As currently all the bubbles have the same size, my proposal would be to leave them as they are. Otherwise that would require substantive changes in the existing markup and CSS styles which would make the uplift to v2.2 more risky. 

Please let me know

thanks

Comment 25

[Mozilla_BEC]

I agree with Jose. I think the vCard icon should take up the same size as the other MMS content boxes.

For layout, what do you think of what I've proposed here?
https://bugzilla.mozilla.org/show_bug.cgi?id=1123435

Comment 26

[Fang Shih [:fang]]

(In reply to Jose Manuel Cantera from comment #24)
> (In reply to Fang Shih [:grasspizza] from comment #22)
> > Created attachment 8556254 [details]
> > SMS_MMS_vcard.png
> > 
> > Attached the vcard view in message bubble. 
> > Also for the icon. I think we don't need to make the vcard icon like the
> > other media placeholders. They are originally a different type of info.
> > Unlike media files. Thanks!
> 
> Hi Fang,
> 
> The proposed layout, although it is cool it would make the bubble sizes
> different depending on the type of attachment. As currently all the bubbles
> have the same size, my proposal would be to leave them as they are.
> Otherwise that would require substantive changes in the existing markup and
> CSS styles which would make the uplift to v2.2 more risky. 
> 
> Please let me know
> 
> thanks

Hi Jose, 
I guess if that would make the uplift to v2.2 more risky. 
We should leave them as they are for now. 
Thanks!

Comment 27

[GitHub Autolander Bot]

Attachment: [PullReq] jmcanterafonseca:icon_mms_vcard to mozilla-b2g:master

Comment 28

[Jose Manuel Cantera]

Comment on attachment 8558977 [details] [review]
[PullReq] jmcanterafonseca:icon_mms_vcard to mozilla-b2g:master

Steve,

As per the comments from Fang. We should be ready to review this patch code-wise.

thanks

Comment 29

[Noemí Freire (:noemi)]

Hi,

A follow up bug (Bug 1129366) has been created to gather the request from UX related to showing the full vcard file name.

Comment 30

[Steve Chung [:steveck]]

Comment on attachment 8558977 [details] [review]
[PullReq] jmcanterafonseca:icon_mms_vcard to mozilla-b2g:master

Some suggestion on github. As I said before the ref type is not only for contact and we should expose one more type for vcard in general.

Comment 31

[Jose Manuel Cantera]

Comment on attachment 8558977 [details] [review]
[PullReq] jmcanterafonseca:icon_mms_vcard to mozilla-b2g:master

Steve,

Your comments have been addressed. Please could you have another look to the code?

thanks!

Comment 32

[Steve Chung [:steveck]]

Attachment: contact active style in bubble

Hi Fang, do we need another styling for actived contact thumbnail? It's current result that applied original thumbnail placeholder styling. Since we'll have different placeholder for vcard, maybe we'll need different styling for actived as well?

Comment 33

[Steve Chung [:steveck]]

Attachment: contact active style in composer

Here is another contact active styling in composer.

Comment 34

[Steve Chung [:steveck]]

Comment on attachment 8558977 [details] [review]
[PullReq] jmcanterafonseca:icon_mms_vcard to mozilla-b2g:master

The js part is fine but I have some concern in contact styling(and the new styling in this patch might break the original styling), so unset the review and let's wait for the Fang's reply, thanks!

Comment 35

[Fang Shih [:fang]]

Attachment: SMS_MMS_vcard_in.png

(In reply to Steve Chung [:steveck] from comment #32)
> Created attachment 8561979 [details]
> contact active style in bubble
> 
> Hi Fang, do we need another styling for actived contact thumbnail? It's
> current result that applied original thumbnail placeholder styling. Since
> we'll have different placeholder for vcard, maybe we'll need different
> styling for actived as well?
Hi Steve, 
We don't need the different styling for it, since that is not like other thumbnail placeholders. Please refer to the file attached for the view of incoming vcard. Thanks!

Comment 36

[Fang Shih [:fang]]

Attachment: icon_smsmms_vcard_imcoming.zip

vcard icon for incoming message.

Comment 37

[Steve Chung [:steveck]]

Some comments and questions on github but I think we're almost there!

Comment 38

[Jose Manuel Cantera]

Hi Steve,

Comments and questions addressed. Plase could you have a look at it?

thanks!

Comment 39

[Julien Wajsberg [:julienw] (PTO -> Mar 16)]

Note that Steve is away for the Chinese New Year until next week, and Oleg and I are in the middle of a meetup. Then because this does not look too urgent I'd suggest to wait for Steve's return. (but I wanted to let you know :) )

Comment 40

[Steve Chung [:steveck]]

Comment on attachment 8558977 [details] [review]
[PullReq] jmcanterafonseca:icon_mms_vcard to mozilla-b2g:master

Looks good to me now, thanks for all the great works!

Comment 41

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/73992beebbf48c4721550f1c9c14315be1148ef3

Comment 42

[Jose Manuel Cantera]

Comment on attachment 8558977 [details] [review]
[PullReq] jmcanterafonseca:icon_mms_vcard to mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): vcard attachments new feature
[User impact] if declined: this has only an impact on the UX, particularly in the visual aspect and the capability of differentiating vcard attachments from other kind of attachments. In our opinion the patch should be uplifted in order to consider the vcard attachments feature as completed. 
[Testing completed]: Unit tests are provided 
[Risk to taking this patch] (and alternatives if risky): Low risk patch- 
[String changes made]: none

Comment 43

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/af250a1627af18ffda7d58a41387cc67a1577a9a