1119398 - [RTL][Browser] Settings icon is left-aligned on the error message

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Browser Chrome, defect, P2)

Description

[Yeojin Chung [:YeojinC]]

Attachment: IconOnLeft.png

Description:
On the network connection error message, the settings icon is located on the left.
   
Pre-requisite: The device has no data or Wi-Fi network connected. 

Repro Steps:
1) Update a Flame device to BuildID: 20150108010221.
2) Set the device language in Arabic under Settings > Language.
3) Open Browser app.
4) Navigate to any website.
5) Observe the network error message.

Actual:
The settings icon is left-aligned.
  
Expected: 
The setting icon is right-aligned.
  
Environmental Variables:
Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash)
BuildID: 20150108010221
Gaia: d4dac29613076bdba3cb8adc217deadb08a2ac20
Gecko: 70de2960aa87
Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76
Version: 37.0a1 (2.2 Master)
Firmware: V188-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
  
Repro frequency: 100%
See attached: screenshot

Comment 1

[Dylan Oliver [:doliver]]

RTL triage: P2 -- will make a best effort to get this into the 2.2 release.

Comment 2

[Dylan Oliver [:doliver]]

RTL update: marking required bugs as feature-b2g:2.2+ (and removing blocking flags)

Comment 4

[Michael Henretty [:mikehenrty][:mhenretty]]

yoink.

Comment 5

[GitHub Autolander Bot]

Attachment: [PullReq] mikehenrty:bug-1119398-rtl-net-error to mozilla-b2g:master

Comment 6

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8560127 [details] [review]
[PullReq] mikehenrty:bug-1119398-rtl-net-error to mozilla-b2g:master

Kevin, wanna take a look?

Comment 7

[Michael Henretty [:mikehenrty][:mhenretty]]

While fixing this bug, I noticed some peculiar behavior with buttons and padding in RTL. I filed bug 1130231 to investigate this. If bug 1130231 is indeed a bug, a fix to that would break the layout of the net_error page in RTL mode. So let's wait for an answer in that bug before landing this fix.

Comment 8

[Kevin Grandon :kgrandon]

Comment on attachment 8560127 [details] [review]
[PullReq] mikehenrty:bug-1119398-rtl-net-error to mozilla-b2g:master

Seems strange to have selectors that are not under #net-error in this css file, but the code looks fine to me. Nice job.

Comment 9

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8560127 [details] [review]
[PullReq] mikehenrty:bug-1119398-rtl-net-error to mozilla-b2g:master

This solution won't work once they fix bug 1130231, which is looks like they are actively working on. I'll fix my patch once that bug lands.

Comment 10

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8560127 [details] [review]
[PullReq] mikehenrty:bug-1119398-rtl-net-error to mozilla-b2g:master

Bug 1130231 has landed in master, so I added the -moz-padding-start selector that is the correct fix here to the existing patch.

Comment 11

[Kevin Grandon :kgrandon]

Comment on attachment 8560127 [details] [review]
[PullReq] mikehenrty:bug-1119398-rtl-net-error to mozilla-b2g:master

lgtm.

Comment 12

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/be9c2f36a1fb7a109139cb78b86a5dbcf3039e07

Comment 13

[Kevin Grandon :kgrandon]

Comment on attachment 8560127 [details] [review]
[PullReq] mikehenrty:bug-1119398-rtl-net-error to mozilla-b2g:master

Would like to uplift this simple RTL fix.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Feature implementation.
[User impact] if declined: Poor RTL experience.
[Testing completed]: Manual, simple css patch.
[Risk to taking this patch] (and alternatives if risky): Low risk, simple css change.
[String changes made]: None.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/18dbc323c097feac3de6315250c101d9658fffdf

Comment 15

[Coler]

This issue has been verified successfully on Flame 3.0.
Reproduce time:0/5.
Attachment:Verify_RTL_Browser.png

Flame 3.0 build:

Gaia-Rev        d5a71cedb37dd45f439f672489db3994b349ac43
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/3094601af679
Build-ID        20150212010213
Version         38.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150212.042740
FW-Date         Thu Feb 12 04:27:51 EST 2015
Bootloader      L1TC000118D0

Comment 16

[Coler]

Attachment: Verify_RTL_Browser.png

Comment 17

[SandKing]

Attachment: Fail log: logcat_1110.txt

This issue has been verified fial on latest Flame2.2
Verify video:"1110.mp4".
See log:"logcat_1110.txt"

Flame 2.2 build:
Build ID               20150216002503
Gaia Revision          ea64caf6d4ab03fc4472eca9f41f20d651d55fa9
Gaia Date              2015-02-13 05:27:43
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/62c80c92b39e
Gecko Version          37.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150216.040540
Firmware Date          Mon Feb 16 04:05:52 EST 2015
Bootloader             L1TC000118D0

Comment 18

[SandKing]

Attachment: Fail video: 1110.mp4

Comment 20

[Augustin Trancart [:autra]]

This does not happen with today v2.2. I'm pretty sure it is the same problem we had in bug 1132646: there was a gecko build that had a bug with -moz-padding-start (see comments 4 and following)

Comment 21

[Augustin Trancart [:autra]]

the qawanted is for 2.2. Master is ok.

Comment 22

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed for 2.2 Flame KK.

Actual Results: The icon is right aligned and does not overlap the text.

Environmental Variables:
Device: Flame 2.2
BuildID: 20150218002515
Gaia: da509caa7395d3d090ce973e8de082b4680a590d
Gecko: 96da179a7d3a
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0