1120222 - give names to AudioOutputStreams of pulseaudio

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, enhancement)

Description

[treaki]

Attachment: Screenshot from 2015-01-11 18:42:00.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Firefox/31.0 Iceweasel/31.2.0
Build ID: 20141102014832

Steps to reproduce:

Visited Playback Tab of pavucontrol on linux running firefox with more then one page acceccing audio outputing features.


Actual results:

I found out that there are more then one stream used by firefox. but they have all the same name. It is possible to adjuce the playback volume for each but it would be easier if ther wouldnt be named all the same.


Expected results:

insted of Audiostream there should be written the name of the site/domain/script or the name of the tab which is playing audio

Comment 1

[Luis D]

Attachment: audio mixer details

Comment 2

[Luis D]

Hello, I want to vote for this feature, I'm using a mixer which allows me to drag apps to different outputs, and when Firefox has more than one tab using audio it becomes a trial and error game.
I think the tab title, can be a good candidate for the name.

Comment 3

[Andreas Pehrson [:pehrsons]]

Removing priority for re-triage within the cubeb component, which is where we integrate with pulseaudio.

Comment 4

[Brendan Early [:mymindstorm]]

Attachment: AudioSink-name-to-title.patch

I have a WIP patch for fixing this with HTMLMediaElement, Web Audio is going to be in a separate patch. It gets the title of the tab and sets the stream name, but it falls behind sometimes (e.g. when switching YouTube videos). This is my first time working with C++, so I'm a bit stumped on how to make this work. If anyone could offer guidance on how to fix this, that would be greatly appreciated.

Comment 5

[Paul Adenot (:padenot)]

Thanks for the patch, a good start indeed!

What's probably missing is to update all this when the page title changes while it's playing a stream. It's well possible that YouTube keeps the same HTMLMediaElement for playing different video, it's a single page app these days.

We don't have an API to update the title when a stream is running, which is something we'd have to add, but it's doesn't look to hard to add something to cubeb for this.

Comment 6

[Brendan Early [:mymindstorm]]

Attachment: Bug 1120222 - Update libcubeb to revision 8d596fe r?padenot

Comment 7

[Brendan Early [:mymindstorm]]

Attachment: Bug 1120222 - Update audioipc to revision c474b0b r?padenot

Depends on D93458

Comment 8

[Brendan Early [:mymindstorm]]

Attachment: Bug 1120222 - Update cubeb Rust components r?padenot

Depends on D93459

Comment 9

[Brendan Early [:mymindstorm]]

Attachment: Bug 1120222 - mach vendor rust r?padenot

Depends on D93460

Comment 10

[Brendan Early [:mymindstorm]]

Attachment: Bug 1120222 - Set AudioSink name to title of MediaElement's parent r?padenot

Depends on D93461

Comment 11

[Paul Adenot (:padenot)]

This is happening in bug 1670917, that is updating all cubeb components (including importing the new OSS backend, that isn't done here). I'll review the gecko patch only https://phabricator.services.mozilla.com/D93462.

Comment 12

[Brendan Early [:mymindstorm]]

Attachment: Bug 1120222 - Set AudioSink name to title of MediaElement's parent r?padenot

Comment 13

[Brendan Early [:mymindstorm]]

Attachment: Bug 1120222 - Part 2 - Add tests r?padenot

Depends on D93462

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd7cfba5859e
Set AudioSink name to title of MediaElement's parent r=padenot
https://hg.mozilla.org/integration/autoland/rev/344c53013a7b
Part 2 - Add tests r=padenot

Comment 15

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/cd7cfba5859e
https://hg.mozilla.org/mozilla-central/rev/344c53013a7b