112031 - Can't create user profile folder when use DBCS as user name

Status: RESOLVED INVALID

(Core :: Internationalization, defect, P3)

Description

[Kasumi]

tested on 2001-11-25-22-0.9.4ec
OS = Win 98

1. Launch Profile manager
2. Click Create profile button and create a new user profile using DBCS as 
   profile name.
   Such as "SHINN YU-ZA" in DBCS Katakana
3. Click Finish button
4. Check C:(maybe)Windows/Application Data/Mozilla/Profiles
   You will not be able to see folder "SHINN YU-ZA", you will have .slt file
   name as folder name instead.

Expected: Create profile folder having DBCS profile name same as SBCS user name
does

Comment 1

[Roy Yokoyama]

*** Bug 112043 has been marked as a duplicate of this bug. ***

Comment 2

[Kasumi]

tested on 2001-11-26-06-trunk
OS = Win XP Ja

There is no problem to have folder having DBCS. 

Comment 3

[Kasumi]

I might need to test using 2001-11-26-06-trunk on some English Windows OS.
Please wait Yokoyama-san.

Comment 4

[Kasumi]

tested on 2001-11-26-06-trunk
OS = Win 98 

The result is the same as 2001-11-25-22-0.9.4ec
Created holder is over written on existing folder which is created prior ec test
having .slt file name as folder name. 

Comment 5

[Roy Yokoyama]

Your comment  #2 means it works in XP-JP
so, is it a Win98 specific bug?

Comment 6

[Kasumi]

No.
Happened on Win 2000 as well.
I think this is regarding English Windows. 

Comment 7

[Teruko Kobayashi]

I take out topembed keyword since this is a general Double byte problem on US 
Windows system.

Comment 8

[Roy Yokoyama]

Ideas: add code to check if the entered profile is a valid.

Comment 9

[Conrad Carlen (not reading bugmail)]

> You will not be able to see folder "SHINN YU-ZA", you will have .slt file
> name as folder name instead.

This makes me suspect nsLocalFile::Append(). Take a look at this:
http://lxr.mozilla.org/mozilla/source/profile/src/nsProfile.cpp#1350

The fact the we're left with only the .slt directory and it's supposed to be the
child dir of the user name (the one that's DBCS) makes me thing the Append() of
a char* when the current leaf node was DBCS failed.

Comment 10

[Frank Tang]

nsbeta1- per triage meeting

Comment 11

[Frank Tang]

nsbta1+ for m1.2final 

Comment 12

[Roy Yokoyama]

Attachment: Patch for XPCOM/IO

Comment 13

[Roy Yokoyama]

Attachment: Patch for History.dat ( db module )

Comment 14

[Roy Yokoyama]

Attachment: support for deleting non-locale Profile files

Comment 15

[Roy Yokoyama]

With above patches, we can create/delete non-locale Profile names and 
file/directories. :)

Comment 16

[Roy Yokoyama]

*** Bug 112741 has been marked as a duplicate of this bug. ***

Comment 17

[Roy Yokoyama]

*** Bug 154629 has been marked as a duplicate of this bug. ***

Comment 18

[Roy Yokoyama]

*** Bug 101573 has been marked as a duplicate of this bug. ***

Comment 19

[Roy Yokoyama]

bulk milestone change

Comment 20

[Roy Yokoyama]

Attachment: fixing indent

Comment 21

[Roy Yokoyama]

cc david for his input.

Comment 22

[David :Bienvenu]

why not use the charset converter for converting between utf8 and unicode? Or
the string routines that do that, instead of adding new code to do it?

Comment 23

[Roy Yokoyama]

Attachment: Calling NS_ConvertUTF8toUCS2()

Oop, I didn't realize that we can call string routines from mork.......

Comment 24

[David :Bienvenu]

you might need to change what mork links against to use the string routines (so
take care of mac, windows, and linux). The original author didn't want Mork to
depend on anything else. I would much rather use existing libraries than rewrite
everything for mork.

Is doing this with a compile time flag really the right way to go? (the answer
could be yes; I don't know). The alternative is to add a new interface to open
unicode file names, or adding a boolean parameter that says file names are in
utf8. That would involve changing all the callers, I guess, but it seems like
you have to change the callers to encode the file names in utf8 anyway.

Comment 25

[David :Bienvenu]

Comment on attachment 106041 [details] [diff] [review]
Calling NS_ConvertUTF8toUCS2()

r=bienvenu, but you need to make sure it builds on all platforms; as I
mentioned before, we might not be linking in the right libs.

Comment 26

[nhottanscp]

right, and depends on platform wchar might not be 2bytes 

Comment 27

[Samir Gehani]

i18n triage team: nsbeta1-

Comment 28

[Frank Tang]

I think both roy and me are off mozilla for more than 2 years. If these bugs are
still here now, I think the real stauts is 'won't fix'. If you want to reopen
it, please find a new owner for it first. 

Comment 29

[Travis Chase]

Mass Reassign Please excuse the spam

Comment 30

[Travis Chase]

Mass Re-opening Bugs Frank Tang Closed on Wensday March 02 for no reason, all
the spam is his fault feel free to tar and feather him

Comment 31

[Travis Chase]

Reassigning Franks old bugs to Jungshik Shin for triage - Sorry for spam