1120427 - Something about the way the emulator uses the sdk caused the all the emulator opt tests to fail

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Emulator, defect, P1)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

When I did the uplift last week, in bug 1114752, all of the emulator tests failed for some reason, which I don't understand yet.

https://hg.mozilla.org/integration/fx-team/rev/2815bfd2ccb5
https://treeherder.mozilla.org/ui/#/jobs?repo=fx-team&revision=2815bfd2ccb5

I could use some help from the emulator folks, my patch for bug 1114752 only touches the add-on sdk, which is tested pretty well, so I figure the emulator is using the sdk in a way that is not tested, which makes me think an sdk tests should have been added with this use case too.

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

The failure appears to be bug 905324, which has existed for some time, I'm not sure why it is consistently failing on the sdk uplift however.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

"AssertionError: Timed out waiting for port!" is a pretty generic error. I'd be extremely surprised if that bug has any relation to your bustage at all besides happening to have the same message. My read is something in your uplift caused the emulator to be unable to start, hence the timeout.

Comment 3

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Hi Vivien, Alex,

Do you guys have any ideas what this may be related to or whom should we be talking to ?

Comment 4

[Alexandre Poirot [:ochameau]]

It could be worth applying this patch and testing it on device, if it breaks the emulator so badly, it may also break the phone and display a meaningful exception when booting it.

Comment 5

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

I'm afraid neither me nor Erik has a device to test with. Erik did find out though that this change seems to be the one causing the emulator test failures:

https://github.com/mozilla/addon-sdk/pull/1723/files#diff-34aa30417456f07d38bc049c7986cedfR378

Alex could you please try & help us figure out how this change could have affected simulator ? We are not familiar with that code & it is really hard for us to guess how that change could have affected simulator.

Comment 6

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

So given that loader changes seem to be at cause here, I tried to search http://mxr.mozilla.org/mozilla-central/search?string=toolkit/loader for loader uses with a hope to track the one that maybe causing this issues.

My only two suspects are either simulator bootstrap.js
http://mxr.mozilla.org/mozilla-central/source/b2g/simulator/bootstrap.js

or devtools loader:
http://mxr.mozilla.org/mozilla-central/source/toolkit/devtools/Loader.jsm

As nothing else other then SDK or few individual tests depend on it.

Comment 7

[Alexandre Poirot [:ochameau]]

That can't be simulator's bootstrap as there is no test involving the simulator on CI tools.
But Loader.jsm is used in various places:
  http://mxr.mozilla.org/mozilla-central/source/b2g/chrome/content/devtools/debugger.js#16
  http://mxr.mozilla.org/mozilla-central/source/b2g/chrome/content/devtools/hud.js#12
  http://mxr.mozilla.org/mozilla-central/source/testing/marionette/marionette-server.js#51

Hopefully, the two first one, even if throwing, don't brick the phones!! (If that does, we should just fix the exception but also ensure that devtools codebase can't possibly brick the phone)
But given how badly broken the tests are, marionette-server is a good candidate!

And the following error seems to confirm that:
http://ftp.mozilla.org/pub/mozilla.org/b2g/tinderbox-builds/fx-team-emulator/1420884314/fx-team_ubuntu64_vm-b2g-emulator_test-xpcshell-bm115-tests1-linux64-build89.txt.gz
http://ftp.mozilla.org/pub/mozilla.org/b2g/tinderbox-builds/fx-team-emulator/1420884314/fx-team_ubuntu64_vm-b2g-emulator_test-mochitest-1-bm67-tests1-linux64-build25.txt.gz
04:15:10     INFO -  01-10 12:10:17.090 I/Gecko   (   44): 1420891817097	Marionette	ERROR	exception: Error, resource://gre/modules/commonjs/sdk/system/xul-app.jsm - EXPORTED_SYMBOLS is not an array.

(It happens at least in failing xpcshell and mochitests)

Comment 8

[Erik Vold [:erikvold] (please needinfo? me)]

(In reply to Alexandre Poirot [:ochameau] from comment #7)
> That can't be simulator's bootstrap as there is no test involving the
> simulator on CI tools.
> But Loader.jsm is used in various places:
>  
> http://mxr.mozilla.org/mozilla-central/source/b2g/chrome/content/devtools/
> debugger.js#16
>  
> http://mxr.mozilla.org/mozilla-central/source/b2g/chrome/content/devtools/
> hud.js#12
>  
> http://mxr.mozilla.org/mozilla-central/source/testing/marionette/marionette-
> server.js#51
> 
> Hopefully, the two first one, even if throwing, don't brick the phones!! (If
> that does, we should just fix the exception but also ensure that devtools
> codebase can't possibly brick the phone)
> But given how badly broken the tests are, marionette-server is a good
> candidate!
> 
> And the following error seems to confirm that:
> http://ftp.mozilla.org/pub/mozilla.org/b2g/tinderbox-builds/fx-team-emulator/
> 1420884314/fx-team_ubuntu64_vm-b2g-emulator_test-xpcshell-bm115-tests1-
> linux64-build89.txt.gz
> http://ftp.mozilla.org/pub/mozilla.org/b2g/tinderbox-builds/fx-team-emulator/
> 1420884314/fx-team_ubuntu64_vm-b2g-emulator_test-mochitest-1-bm67-tests1-
> linux64-build25.txt.gz
> 04:15:10     INFO -  01-10 12:10:17.090 I/Gecko   (   44): 1420891817097
> Marionette	ERROR	exception: Error,
> resource://gre/modules/commonjs/sdk/system/xul-app.jsm - EXPORTED_SYMBOLS is
> not an array.
> 
> (It happens at least in failing xpcshell and mochitests)

Ah thank you Alex! I did not see this error which is very helpful.

So the error above is caused by Bug 1037235.

I also see this following error in https://tbpl.mozilla.org/php/getParsedLog.php?id=56576322&tree=Try&full=1

22:17:29     INFO -  01-15 06:12:33.850 I/GeckoConsole(   44): While creating services from category 'profile-after-change', could not create service for entry 'Nfc', contract ID '@mozilla.org/nfc;1'
22:17:29     INFO -  01-15 06:12:33.940 I/GeckoConsole(   44): While creating services from category 'profile-after-change', could not create service for entry 'NfcContentHelper', contract ID '@mozilla.org/nfc/content-helper;1'
22:17:29     INFO -  01-15 06:12:35.691 I/Gecko   (   44): 1421302355692	Marionette	INFO	marionette-server.js loaded
22:17:29     INFO -  01-15 06:12:36.741 I/Gecko   (   44): 1421302356744	Marionette	ERROR	exception: Error, resource://gre/modules/commonjs/toolkit/loader.js - EXPORTED_SYMBOLS is not an array.

This is caused by Bug 1102107.

Comment 9

[BMO Automation]

Firefox OS is not being worked on