Status

()

Firefox for iOS
Reader View
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: st3fan, Assigned: st3fan)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

46 bytes, text/x-github-pull-request
Details | Review | Splinter Review
(Assignee)

Description

3 years ago
Implement a Reader Mode that behaves the same way as Reader Mode on Android. Try to reuse the existing style sheets and Readability engine as much as possible so that there is more commonality between the different implementations.
(Assignee)

Comment 1

3 years ago
Created attachment 8548346 [details] [review]
Pull Request

This is a first rough implementation of Reader Mode. I would like to merge this so that we can get an idea of how this works and start filing followup bugs for both UI and code issues.

I want to iterate rather quickly on this, and it will be nice to get at least some working code in there now to enable that.
(Assignee)

Updated

3 years ago
Attachment #8548346 - Flags: review?(bnicholson)
Status: NEW → ASSIGNED
OS: Mac OS X → iOS 8
Hardware: x86 → All
Comment on attachment 8548346 [details] [review]
Pull Request

Flagging me so I remember to look at the data model.
Attachment #8548346 - Flags: feedback?(rnewman)
Comment on attachment 8548346 [details] [review]
Pull Request

Only thing I see that doesn't line up with Android (yet) is excerpt/word count. The latter needs some effort around locale detection etc. (Bug 1106380).
Attachment #8548346 - Flags: feedback?(rnewman) → feedback+
Comment on attachment 8548346 [details] [review]
Pull Request

Left several questions/comments in the PR. r=me as long as they're answered/addressed, or follow-up bugs are filed to fix them.
Attachment #8548346 - Flags: review?(bnicholson) → review+
(Assignee)

Comment 5

3 years ago
Created attachment 8549991 [details] [review]
Pull Request

New PR since I messed up git squash. Also removed reader mode button UI code since I have a much better solution for that already.
Attachment #8548346 - Attachment is obsolete: true
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Blocks: 1127017
You need to log in before you can comment on or make changes to this bug.