1904014 - Remove function to do an empty search using the search bar one-off buttons.

Status: VERIFIED FIXED

(Firefox :: Search, task, P2)

Description

[Moritz Beier [:mbeier]]

As part of the removal of SearchEngine.searchForm the one-off buttons in the search bar popup should be changed to only start a search when the search bar is not empty.
Previously they could be used to open the searchForm url but since that is gone now, pressing them when the search bar is empty results in a search for "".

Comment 1

[Moritz Beier [:mbeier]]

Attachment: Bug 1904014 - Remove function to do an empty search using the search bar one-off buttons. r?standard8

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80bffab6cb97
Remove function to do an empty search using the search bar one-off buttons. r=Standard8

Comment 3

[pstanciu]

Backed out for causing bc failures on browser_oneOffContextMenu.js

• Backout link
• Push with failures
• Failure Log

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d796b34b249
Remove function to do an empty search using the search bar one-off buttons. r=Standard8

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/4d796b34b249

Comment 6

[Moritz Beier [:mbeier]]

Attachment: Bug 1904014 - Remove function to do an empty search using the search bar one-off buttons. r?standard8

Original Revision: https://phabricator.services.mozilla.com/D214834

Comment 7

[Moritz Beier [:mbeier]]

Attachment: Bug 1904014 - Remove function to do an empty search using the search bar one-off buttons. r?standard8

Original Revision: https://phabricator.services.mozilla.com/D214834

Comment 8

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: User will be able to start a search with an empty query. This will lead to error pages being displayed on some search engines.
• Code covered by automated testing: yes
• Fix verified in Nightly: yes
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: Add search bar, click magnifying glass in search bar (opens popup), click on a search engine icon. Nothing should happen. Repeat but do right click -> open in new tab instead.
• Risk associated with taking this patch: little
• Explanation of risk level: Few and simple changes to non-test code
• String changes made/needed: No
• Is Android affected?: no

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/2759da16cfee

Comment 10

[Cristian Baica [:cbaica], Release Desktop QA]

The issue is verified fixed using the latest Fx 130.0a1 and Fx 129.0b9 on Windows 10 and Ubuntu 23.04.
Search bar searches with empty query no longer open the opens the search engine page.

Comment 11

[Manuel Bucher [:manuel] {{ FYI: OOO until 6 October }}]

Adding related bugs for context due to seeing reports on Matrix for this functionality missing.