1120750 - [Text Selection]Send out caret's position for the short cut mode

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect, P2)

Description

[Peter Chang[:pchang]]

This bug is created based on bug 1117684 comment 3 and I just clone the comment in the following.

1. launch bubble by touchcarettap on column A, then long tap on empty column B, the bubble's position seems incorrect. We need a selectionchanged event from gecko when long tapping column B.

Comment 1

[Peter Chang[:pchang]]

Un-assign myself. Morris, please check this issue with Jeremy.

Comment 2

[Peter Chang[:pchang]]

Feel free to assign to others if you are not the right owner

Comment 3

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Part 1: Move GetSelectionBoundingRect to nsContentUtils.

Comment 4

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Part 2: Add touchcarettap to SelectionState.

Comment 5

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Part 3: Dispatch touchcarettap using selectionstatechanged event.

Comment 6

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Part 4: Remove all touchcarettap event listener.

Comment 7

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Part 1: Move GetSelectionBoundingRect to nsContentUtils v2.

Fix build break.

Comment 8

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Part 1: Move GetSelectionBoundingRect to nsContentUtils v3.

fix build break again.

Comment 9

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Part 2: Add taponcaret to SelectionState v2.

Rename reason name.

Comment 10

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Part 3: Dispatch taponcaret using selectionstatechanged event v2.

Rename reason name.

Comment 11

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Gaia wip patch.

Comment 12

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Part 3: Dispatch taponcaret using selectionstatechanged event v3.

fix typo

Comment 13

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 8552903 [details] [diff] [review]
Part 1: Move GetSelectionBoundingRect to nsContentUtils v3.

Review of attachment 8552903 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/base/nsContentUtils.h
@@ +2168,5 @@
>                                          int32_t& aOutStartOffset,
>                                          int32_t& aOutEndOffset);
>  
>    /**
> +   * Takes a selection, and return selection's bounding rect.

You need to say what the rect is relative to.

Comment 14

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Part 1: Move GetSelectionBoundingRect to nsContentUtils v4. (carry r+: roc)

Update to reviewer's comment

Comment 15

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Part 4: Remove all touchcarettap event listener v2. (carry r+: roc)

Rebased.

Comment 16

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f18284c5647c

Comment 17

[howie [:howie]]

Triage: blocker

Comment 18

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Part 1: Move GetSelectionBoundingRect to nsContentUtils v5. (carry r+: roc)

Rebased.

Comment 19

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8559595 [details] [diff] [review]
Part 1: Move GetSelectionBoundingRect to nsContentUtils v5. (carry r+: roc)

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: The position of shortcut bubble for copy/paste would be wrong when it appears.
Testing completed: on master
Risk to taking this patch (and alternatives if risky): low risk.
String or UUID changes made by this patch: none

Comment 20

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8552929 [details] [diff] [review]
Part 2: Add taponcaret to SelectionState v2.

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: The position of shortcut bubble for copy/paste would be wrong when it appears.
Testing completed: on master
Risk to taking this patch (and alternatives if risky): low risk.
String or UUID changes made by this patch: none

Comment 21

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8552934 [details] [diff] [review]
Part 3: Dispatch taponcaret using selectionstatechanged event v3.

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: The position of shortcut bubble for copy/paste would be wrong when it appears.
Testing completed: on master
Risk to taking this patch (and alternatives if risky): low risk.
String or UUID changes made by this patch: none

Comment 22

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Comment on attachment 8555694 [details] [diff] [review]
Part 4: Remove all touchcarettap event listener v2. (carry r+: roc)

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: The position of shortcut bubble for copy/paste would be wrong when it appears.
Testing completed: on master
Risk to taking this patch (and alternatives if risky): low risk.
String or UUID changes made by this patch: none

Comment 23

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Looks like we have gij failed on try. Clear checkin-needed first.

Comment 24

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Looks like my try on gij didn't fetch latest gaia. With latest gaia on my local machine, it looks well. Add checkin-needed again.

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=68f0c7b0442b

Comment 25

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

More precisely, we need gaia after this commit. https://git.mozilla.org/?p=releases/gaia.git;a=commit;h=827389929cc20dda5ade6e887d99894905f4f7b9

Comment 26

[(PTO June 19-July 7) Ryan VanderMeulen]

Sorry, but I'd like to see a green Try run that includes the Gaia commit in question.

Comment 27

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Here is try with positive result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=02d599d6ff56

Comment 28

[(PTO June 19-July 7) Ryan VanderMeulen]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cc0142c8a550
https://hg.mozilla.org/integration/mozilla-inbound/rev/09a80c23ad56
https://hg.mozilla.org/integration/mozilla-inbound/rev/6e376c78c31b
https://hg.mozilla.org/integration/mozilla-inbound/rev/db6c43f3ce1b

Comment 29

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cc0142c8a550
https://hg.mozilla.org/mozilla-central/rev/09a80c23ad56
https://hg.mozilla.org/mozilla-central/rev/6e376c78c31b
https://hg.mozilla.org/mozilla-central/rev/db6c43f3ce1b

Comment 30

[(PTO June 19-July 7) Ryan VanderMeulen]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/4188a0712a69
https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/ab83a2e7d58a
https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/6d2fe1328424
https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/f712597a634b

Comment 31

[(PTO June 19-July 7) Ryan VanderMeulen]

Backed out for Linux32 bustage.
https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/e2d8cc7b5b08

https://treeherder.mozilla.org/logviewer.html#?job_id=34826&repo=mozilla-b2g37_v2_2

Comment 32

[Morris Tseng [:mtseng] [:Morris] (Inactive)]

Attachment: Part 5: Fix non-unified build bustage.

Tested it in my local machine.

Comment 33

[(PTO June 19-July 7) Ryan VanderMeulen]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/5382fb4a631f
https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/d9b4ba078d96
https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/b19f82816eb2
https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/d02e52365bf9
https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/541555f581b4

Comment 34

[(PTO June 19-July 7) Ryan VanderMeulen]

Landed the bustage fix on b2g-inbound as well to keep the branches in sync.
https://hg.mozilla.org/integration/b2g-inbound/rev/197838b4972e

Comment 35

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/197838b4972e