1117684 - [Text Selection] Paste icon is not showing up

Status: RESOLVED DUPLICATE of bug 1110963

(Firefox OS Graveyard :: Gaia, defect, P2)

Description

[Teri Wen [:twen]]

### STR
1. Open Messages app
2. Tap new message icon
3. Input some characters "12345"
4. Long press on any character of 12345
5. Tap cut icon
6. Tap on message field 

### Actual
no paste icon

### Expected
Paste icon to appear

### Version
Gaia-Rev        c2bf20d23851d5fda9f8f0ef0267db5f49152376
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/636498d041b5
Build-ID        20150104160203
Version         37.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141221.192512
FW-Date         Sun Dec 21 19:25:23 EST 2014
Bootloader      L1TC00011880

Comment 1

[Peter Chang[:pchang]]

George, I think this is related to shortcut mode. Please help to check it.

Comment 2

[(Inactive after June) George Duan [:gduan] [:喬智]]

I think it's not related to shortcut mode. If it takes less than 15 seconds between step 5 and step 6, the bubble shows correctly.

However, if it takes longer, user should be able to long-press the empty column to launch the bubble, which may go wrong here. The problem we have is, when we do longpress on empty column, gaia actually display last selectionchanged event, so, if the screen has resized, the position might go wrong.

Comment 3

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR to master

Waiting for test.

Hi Peter,

There're still two significant issues.
1. launch bubble by touchcarettap on column A, then long tap on empty column B, the bubble's position seems incorrect. We need a selectionchanged event from gecko when long tapping column B.
2. launch bubble by touchcarettap on non empty column, then tap any key of keyboard, the bubble doesn't disappear. Gaia doesn't get any event when tapping keyboard.

Comment 4

[Peter Chang[:pchang]]

(In reply to George Duan [:gduan] [:喬智] from comment #3)
> Created attachment 8547491 [details] [review]
> PR to master
> 
> Waiting for test.
> 
> Hi Peter,
> 
> There're still two significant issues.
> 1. launch bubble by touchcarettap on column A, then long tap on empty column
> B, the bubble's position seems incorrect. We need a selectionchanged event
> from gecko when long tapping column B.
Created 1120750 to follow up this issue.
> 2. launch bubble by touchcarettap on non empty column, then tap any key of
> keyboard, the bubble doesn't disappear. Gaia doesn't get any event when
> tapping keyboard.

Created 1120754 to follow up this issue but I would prefer to fix this issue for v3 since the bubble will be gone after timeout(3 sec)

Comment 5

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8547491 [details] [review]
PR to master

Hi Alive,
could I have your review on this patch?
It has fixed this issue and separated shortcut from onselectionchanged logic.

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8547491 [details] [review]
PR to master

Since this is going further complex, I expect to see a document or slide to explain how the state changes inside the text selection.

Comment 7

[(Inactive after June) George Duan [:gduan] [:喬智]]

Just check the latest master, this main issue is already fixed by bug 1110963.


The refactoring plan is still ongoing. Since few things would be changed in gaia side, I would provide document once it's fixed.