1121774 - Split EME MSE tests into one stream per sourcebuffer

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P2)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

Instead of having audio and video in the same file for the EME MSE test cases, we should split out the audio and video into separate files and sourcebuffers.

Comment 1

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Attachment: Make gizmo MSE+EME test cases video-only

Comment 2

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Attachment: Use bipbop.mp4 and separate video and audio into different streams.

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Reopening, to split EME test files into separate audio&video streams.

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: 1121774-v2.patch use multi-stream bipbop mp4

Added encrypted bipbop mp4 with separate audio and video streams, each sent to a different sourcebuffer. Updated all EME tests to use that (both a single-stream video-only, and a double-stream audio+video).

Comment 5

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4fc3747b72cd
Note: The Mac failure is currently happening everywhere, see bug 1142006.

Comment 6

[Edwin Flores [inactive from 2016-12-01] [:eflores] [:edwin]]

Comment on attachment 8576267 [details] [diff] [review]
1121774-v2.patch use multi-stream bipbop mp4

Review of attachment 8576267 [details] [diff] [review]:
-----------------------------------------------------------------

Consider encrypting each track with its own encryption XML containing only the key it uses; although I'm not sure we handle that case properly. Would be good to know.

::: dom/media/test/bipbop-frag-cenc.xml
@@ +18,1 @@
>    

nit: Trailing whitespace from the original file here. Let's remove it.

::: dom/media/test/eme.js
@@ +325,5 @@
> +  // EME doesn't support non-MSE source.
> +  return new Promise(function(resolve, reject) {
> +    ok(false, token + " test does not have a fragments or tracks list");
> +    reject();
> +  });

return Promise.reject();

Comment 7

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: 1121774-v2.patch with r+ comments addressed

r+ comments addressed; except for separate encryption XMLs, see bug 1142379.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/95c59acdcf72

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/95c59acdcf72