Closed Bug 1121774 Opened 5 years ago Closed 5 years ago

Split EME MSE tests into one stream per sourcebuffer

Categories

(Core :: Audio/Video, defect, P2)

x86_64
All
defect

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: cpearce, Assigned: gerald)

References

(Blocks 3 open bugs)

Details

Attachments

(1 file, 3 obsolete files)

Instead of having audio and video in the same file for the EME MSE test cases, we should split out the audio and video into separate files and sourcebuffers.
Priority: -- → P2
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → WONTFIX
Reopening, to split EME test files into separate audio&video streams.
Assignee: edwin → gsquelart
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Added encrypted bipbop mp4 with separate audio and video streams, each sent to a different sourcebuffer. Updated all EME tests to use that (both a single-stream video-only, and a double-stream audio+video).
Attachment #8549358 - Attachment is obsolete: true
Attachment #8549361 - Attachment is obsolete: true
Attachment #8576267 - Flags: review?(edwin)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4fc3747b72cd
Note: The Mac failure is currently happening everywhere, see bug 1142006.
Comment on attachment 8576267 [details] [diff] [review]
1121774-v2.patch use multi-stream bipbop mp4

Review of attachment 8576267 [details] [diff] [review]:
-----------------------------------------------------------------

Consider encrypting each track with its own encryption XML containing only the key it uses; although I'm not sure we handle that case properly. Would be good to know.

::: dom/media/test/bipbop-frag-cenc.xml
@@ +18,1 @@
>    

nit: Trailing whitespace from the original file here. Let's remove it.

::: dom/media/test/eme.js
@@ +325,5 @@
> +  // EME doesn't support non-MSE source.
> +  return new Promise(function(resolve, reject) {
> +    ok(false, token + " test does not have a fragments or tracks list");
> +    reject();
> +  });

return Promise.reject();
Attachment #8576267 - Flags: review?(edwin) → review+
Blocks: 1142379
r+ comments addressed; except for separate encryption XMLs, see bug 1142379.
Attachment #8576267 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/95c59acdcf72
Status: REOPENED → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Blocks: 1173650
You need to log in before you can comment on or make changes to this bug.