Closed Bug 1142379 Opened 5 years ago Closed 5 years ago

EME tests: Encrypt audio and video tracks using separate encryption settings

Categories

(Core :: Audio/Video, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla40
Tracking Status
firefox40 --- fixed

People

(Reporter: gerald, Assigned: gerald)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file, 2 obsolete files)

As per bug 1121774 comment 6:
"Consider encrypting each track with its own encryption XML containing only the key it uses; although I'm not sure we handle that case properly. Would be good to know."

Currently the test in bug 1121774 provides all keys in both streams, and only handles the first 'encrypted' event assuming that it contains all that is need.

Instead each stream should only contain the keys it requires, and the test should handle all corresponding 'encrypted' events.
The video and audio tracks of bipbop-cenc1-* only contain encryption keys for themselves, not each other.
Updated EME tests to handle each 'encrypted' event and start a corresponding session.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f93544c98df7
Attachment #8577074 - Flags: review?(edwin)
Blocks: 1138294
Depends on: 1144409
Updated, better test names; Also fixed probably canvas test issue.
Attachment #8577074 - Attachment is obsolete: true
Attachment #8577074 - Flags: review?(edwin)
Attachment #8579777 - Flags: review?(edwin)
Short EME tests didn't wait for loading to complete before declaring the test finished, sometimes causing issues when post-load decrypting was trying to use objects that were cleaned up.
Attachment #8579777 - Attachment is obsolete: true
Attachment #8581320 - Flags: review?(edwin)
checkin-needed please, *after* bug 1144409.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4f902c54a371
Keywords: checkin-needed
Whiteboard: check in bug 1144409 first!
https://hg.mozilla.org/integration/mozilla-inbound/rev/c58f5ffb38e0
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: check in bug 1144409 first!
Blocks: 1146563
I had to back this out for the various EME test failures that started happening after this landed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e55d9b57b37b
Flags: needinfo?(gsquelart)
This test doesn't need to block Adobe MVP.
Priority: -- → P2
Working on more focused EME tests, to try and deal with all issues; starting with bug 1148179.
Flags: needinfo?(gsquelart)
Priority: P2 → P1
Depends on: 1148179
Blocks: 1152170
Priority: P1 → P2
https://hg.mozilla.org/mozilla-central/rev/6b0986903758
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
See Also: → 1173650
You need to log in before you can comment on or make changes to this bug.