1142379 - EME tests: Encrypt audio and video tracks using separate encryption settings

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P2)

Description

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

As per bug 1121774 comment 6:
"Consider encrypting each track with its own encryption XML containing only the key it uses; although I'm not sure we handle that case properly. Would be good to know."

Currently the test in bug 1121774 provides all keys in both streams, and only handles the first 'encrypted' event assuming that it contains all that is need.

Instead each stream should only contain the keys it requires, and the test should handle all corresponding 'encrypted' events.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: 1142379.patch Added bipbop requiring separate encrypted sessions per track

The video and audio tracks of bipbop-cenc1-* only contain encryption keys for themselves, not each other.
Updated EME tests to handle each 'encrypted' event and start a corresponding session.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f93544c98df7

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: 1142379.patch Added bipbop requiring separate encrypted sessions per track - v2

Updated, better test names; Also fixed probably canvas test issue.

Comment 3

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: 1142379.patch Minor update for short tests not to finish too soon

Short EME tests didn't wait for loading to complete before declaring the test finished, sometimes causing issues when post-load decrypting was trying to use objects that were cleaned up.

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

checkin-needed please, *after* bug 1144409.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4f902c54a371

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c58f5ffb38e0

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to back this out for the various EME test failures that started happening after this landed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e55d9b57b37b

Comment 7

[Chris Peterson [:cpeterson]]

This test doesn't need to block Adobe MVP.

Comment 8

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Working on more focused EME tests, to try and deal with all issues; starting with bug 1148179.

Comment 9

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Trying with patch from bug 1154133:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=19326a3604ff

Comment 10

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6b0986903758

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6b0986903758