1121834 - B2G RIL: dun support on L

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Jessica Jong [:jessica] (inactive)]

On L, every network interface has its own routing table, so I guess dun will work fine. Nevertheless, we should still verify it after bug 1104664 and avoid sending old commands to netd on L.

Comment 1

[Jessica Jong [:jessica] (inactive)]

Tested locally with patches in bug 1104664 and bug 116434 - dun works after adding default route on dun network routing table.

Comment 2

[Jessica Jong [:jessica] (inactive)]

(In reply to Jessica Jong [:jjong] [:jessica] from comment #1)
> Tested locally with patches in bug 1104664 and bug 116434 - dun works after
                                                  ^^^^^^^^^^
                                             I mean bug 1116434
> adding default route on dun network routing table.

Comment 3

[Keven Kuo [:kkuo]]

Hi! Jessica,

Could you confirm that this case is also fixed when both bug 1104664 and bug 1116434 are done?
Thanks

--
Keven

Comment 4

[Jessica Jong [:jessica] (inactive)]

(In reply to Keven Kuo [:kkuo] from comment #3)
> Hi! Jessica,
> 
> Could you confirm that this case is also fixed when both bug 1104664 and bug
> 1116434 are done?
> Thanks
> 
> --
> Keven

Hi Keven, in addition to bug 1104664 and bug 1116434, this case still requires some modifications in NetworkUtils to adapt the new netd commands. I'm working on it and will finish before end of the week.

Comment 5

[Jessica Jong [:jessica] (inactive)]

Attachment: propsed patch, v1.

I just changed the command in 'add/removeSecondaryRoute()' for L. And also moved clearing default routes in NetworkManager earlier, to avoid default route in secondary table being cleared in L.

Edgar, may I have your review on this? Thanks.

Comment 6

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Comment on attachment 8552291 [details] [diff] [review]
propsed patch, v1.

Review of attachment 8552291 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, thank you.

Comment 7

[Jessica Jong [:jessica] (inactive)]

Thanks Edgar!

try look goods:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=23d74856a3e5&exclusion_state=all

Comment 8

[Jessica Jong [:jessica] (inactive)]

https://hg.mozilla.org/integration/b2g-inbound/rev/92403a09095d

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/92403a09095d

Comment 10

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

L porting is must-have to 2.2, so I'm setting feature-b2g:2.2+.
Please ask approval to uplift.

Comment 11

[Jessica Jong [:jessica] (inactive)]

Comment on attachment 8552291 [details] [diff] [review]
propsed patch, v1.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): N/A
User impact if declined: dun tethering will not work on Lollipop
Testing completed: try and manually tested
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: N/A

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/89db1156c40d