1116434 - (gonk-L-Wifi) WiFi hotspot L porting

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Wifi, defect)

Comment 1

[Hermes Cheng (inactive after July 27, 2015)]

After wifi porting is done, wifi hotspot functionality should be verified.

Comment 2

[Vincent Chang[:vchang][changyihsin]]

Jessica is working on this.

Comment 3

[Vincent Chang[:vchang][changyihsin]]

Wifi hotspot should be mandatory function. Nominate it for feature 2.2+

Comment 4

[Jessica Jong [:jessica] (inactive)]

This is how the routing table looks like when tethering is enabled:

root@mako:/ # ip rule
0:	from all lookup local 
10000:	from all fwmark 0xc0000/0xd0000 lookup legacy_system 
13000:	from all fwmark 0x10063/0x1ffff lookup local_network 
13000:	from all fwmark 0x10064/0x1ffff lookup rmnet_usb0 
14000:	from all oif rmnet_usb0 lookup rmnet_usb0 
14000:	from all oif wlan0 lookup local_network 
15000:	from all fwmark 0x0/0x10000 lookup legacy_system 
16000:	from all fwmark 0x0/0x10000 lookup legacy_network 
17000:	from all fwmark 0x0/0x10000 lookup local_network 
18000:	from all iif wlan0 lookup rmnet_usb0 
19000:	from all fwmark 0x64/0x1ffff lookup rmnet_usb0 
22000:	from all fwmark 0x0/0xffff lookup rmnet_usb0 
23000:	from all fwmark 0x0/0xffff uidrange 0-0 lookup main 
32000:	from all unreachable

We can see that there are "iif -> oif" rules for tethering.
The iif rule is created "nat enable" command is sent to netd. For the oif rule, we have to add the tethering interface to the local network and then add the corresponding route into local_network table.

Also, netid fwmark is passed to dnsmasq to use for DNS queries.

I'll provide a patch once bug 1104664 is ready.

Comment 5

[Jessica Jong [:jessica] (inactive)]

Attachment: WIP (based on bug 1104664 WIP6)

Comment 6

[Henry Chang [:hchang]]

Attachment: Bug1116434.patch (based on Bug 1104664)

Comment 7

[Jessica Jong [:jessica] (inactive)]

(In reply to Henry Chang [:henry] from comment #6)
> Created attachment 8546491 [details] [diff] [review]
> Bug1116434.patch (based on Bug 1104664)

I'll upload the final patch and ask for review once bug 1104664 is landed.

Comment 8

[Jessica Jong [:jessica] (inactive)]

Attachment: patch, v1.

Comment 9

[Jessica Jong [:jessica] (inactive)]

Attachment: patch, v2.

remove unused variable.

Comment 10

[Jessica Jong [:jessica] (inactive)]

Comment on attachment 8550062 [details] [diff] [review]
patch, v2.

Edgar, may I have your review on this? Thanks!

Comment 11

[Edgar Chen [:edgar] (PTO untils 8/11, slow response)]

Comment on attachment 8550062 [details] [diff] [review]
patch, v2.

Review of attachment 8550062 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thank you.

::: dom/system/gonk/NetworkUtils.cpp
@@ +742,5 @@
>    doCommand(command, aChain, aCallback);
>  }
>  
> +void NetworkUtils::addInterfaceToLocalNetwork(CommandChain* aChain,
> +                                          CommandCallback aCallback,

Nit: Indention

Comment 12

[Jessica Jong [:jessica] (inactive)]

Attachment: final patch. r=echen

- correct indention (see comment 11)

Thanks Edgar!

Comment 13

[Jessica Jong [:jessica] (inactive)]

try looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=77eb6c0f3e48

Comment 14

[Jessica Jong [:jessica] (inactive)]

https://hg.mozilla.org/integration/b2g-inbound/rev/a8cc493dc516

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a8cc493dc516

Comment 17

[Vincent Chang[:vchang][changyihsin]]

Comment on attachment 8551615 [details] [diff] [review]
final patch. r=echen

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Wifi/USB hotspot L porting
User impact if declined: Wifi and USB hotspot will not work
Testing completed: Yes
Risk to taking this patch (and alternatives if risky): No
String or UUID changes made by this patch: No

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/f33729c0c8fe