1121874 - Twitter authorization step fails by showing login or 404 screen

Status: RESOLVED FIXED

(Chat Core :: Twitter, defect)

Description

[Ajit]

Attachment: instantbird issue twitter authorization issue.jpg

User Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0
Build ID: 20141126041045

Steps to reproduce:

Added twitter username, local alias, connect this account automatically - ticked, clicked Finish.

Twitter authorize app window pops up, entered username and password, clicked Authorize app


Actual results:

Twitter authorize app window redirected back to twitter log in screen. But now unable to type in password. Please see the screenshot attachment.


Expected results:

Twitter authorization

Comment 1

[Patrick Cloke [:clokep]]

This seems related to bug 1121874.

Comment 2

[aleth [:aleth]]

(In reply to Patrick Cloke [:clokep] from comment #1)
> This seems related to bug 1121874.

You meant bug 1068397.

Comment 3

[Ajit]

(In reply to aleth [:aleth] from comment #2)
> (In reply to Patrick Cloke [:clokep] from comment #1)
> > This seems related to bug 1121874.
> 
> You meant bug 1068397.

Comment 4

[Ajit]

(In reply to aleth [:aleth] from comment #2)
> (In reply to Patrick Cloke [:clokep] from comment #1)
> > This seems related to bug 1121874.
> 
> You meant bug 1068397.

What is the solution? Please advise.

Comment 5

[Ajit]

Hi,

Still no resolution?

Comment 6

[aleth [:aleth]]

I just tried to reproduce this in a TB daily build and everything seems to work fine there.

I also couldn't reproduce this in Bug 1068397.

Does this problem still occur?

Comment 7

[aleth [:aleth]]

OK, so it looks like I can reproduce something like this on Instantbird. But instead of the login page the second page I get is the twitter 404 page with a searchbox.

Comment 8

[aleth [:aleth]]

The difference between IB and TB led me to suspect a cookie issue, and indeed setting network.cookie.cookieBehaviour to 0 made the authorization complete successfully.

It would be very helpful to know if this also works for the reporters of this bug.

Comment 9

[aleth [:aleth]]

(In reply to aleth [:aleth] from comment #8)
> The difference between IB and TB led me to suspect a cookie issue, and
> indeed setting network.cookie.cookieBehaviour to 0 made the authorization
> complete successfully.

Sorry, it's network.cookie.cookieBehavior. US spelling...

Comment 11

[aleth [:aleth]]

It's been confirmed setting the pref works as as workaround. [https://bugzilla.mozilla.org/show_bug.cgi?id=1156547#c2]

Comment 12

[aleth [:aleth]]

To fix this, we should probably change the pref (in sync with TB, which would also unblock the Filelink patch) and replace it with removing the cookies after auth is complete, using

http://mxr.mozilla.org/mozilla-central/source/browser/components/preferences/aboutPermissions.js#205

Comment 13

[aleth [:aleth]]

Attachment: twittercookies.diff

Comment 14

[aleth [:aleth]]

Attachment: twittercookies.diff v2

Keep explanatory comment.

Comment 15

[Patrick Cloke [:clokep]]

Comment on attachment 8596179 [details] [diff] [review]
twittercookies.diff v2

Review of attachment 8596179 [details] [diff] [review]:
-----------------------------------------------------------------

r+ assuming you tested this by creating multiple accounts in the same session.

Comment 16

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/2c13ad27779f

Comment 17

[aleth [:aleth]]

(In reply to Patrick Cloke [:clokep] from comment #15)
> r+ assuming you tested this by creating multiple accounts in the same
> session.

Yes, that works fine.

Comment 18

[aleth [:aleth]]

Comment on attachment 8596179 [details] [diff] [review]
twittercookies.diff v2

[Approval Request Comment]
User impact if declined: Currently TB38 will encounter bug 954308 if you try to add two twitter accounts in the same session. This patch fixes that for TB.
Risk to taking this patch (and alternatives if risky): None, unless someone is relying on twitter.com cookies in TB ;)

Comment 19

[Kent James (:rkent)]

Comment on attachment 8596179 [details] [diff] [review]
twittercookies.diff v2

http://hg.mozilla.org/releases/comm-aurora/rev/7203a728a4c9
http://hg.mozilla.org/releases/comm-beta/rev/ec05ac90e575