1121900 - [flatfish] build break by "error: undefined reference to 'mozilla::dom::MozIsoDepTech::mTechnology'"

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Danny Liang [:dliang]]

Attachment: build.log.2

The error message as following:

/home/dannyliang/work/codes/b2g_flatfish_github/prebuilts/gcc/linux-x86/arm/arm-linux-androideabi-4.6/bin/../lib/gcc/arm-linux-androideabi/4.6.x-google/../../../../arm-linux-androideabi/bin/ld: warning: hidden symbol '__dso_handle' in /home/dannyliang/work/codes/b2g_flatfish_github/objdir-gecko/toolkit/library/../../media/kiss_fft/kiss_fft.o is referenced by DSO ../../security/sandbox/linux/libmozsandbox.so
/home/dannyliang/work/codes/b2g_flatfish_github/prebuilts/gcc/linux-x86/arm/arm-linux-androideabi-4.6/bin/../lib/gcc/arm-linux-androideabi/4.6.x-google/../../../../arm-linux-androideabi/bin/ld: warning: hidden symbol '__dso_handle' in /home/dannyliang/work/codes/b2g_flatfish_github/objdir-gecko/toolkit/library/../../media/kiss_fft/kiss_fft.o is referenced by DSO ../../config/external/nss/libnss3.so
/home/dannyliang/work/codes/b2g_flatfish_github/prebuilts/gcc/linux-x86/arm/arm-linux-androideabi-4.6/bin/../lib/gcc/arm-linux-androideabi/4.6.x-google/../../../../arm-linux-androideabi/bin/ld: warning: hidden symbol 'vorbis_info_init' in /home/dannyliang/work/codes/b2g_flatfish_github/objdir-gecko/toolkit/library/../../media/libtremor/lib/tremor_info.o is referenced by DSO /home/dannyliang/work/codes/b2g_flatfish_github/out/target/product/flatfish/obj/lib/libstagefright.so
/home/dannyliang/work/codes/b2g_flatfish_github/prebuilts/gcc/linux-x86/arm/arm-linux-androideabi-4.6/bin/../lib/gcc/arm-linux-androideabi/4.6.x-google/../../../../arm-linux-androideabi/bin/ld: warning: hidden symbol 'vorbis_comment_init' in /home/dannyliang/work/codes/b2g_flatfish_github/objdir-gecko/toolkit/library/../../media/libtremor/lib/tremor_info.o is referenced by DSO /home/dannyliang/work/codes/b2g_flatfish_github/out/target/product/flatfish/obj/lib/libstagefright.so
/home/dannyliang/work/codes/b2g_flatfish_github/prebuilts/gcc/linux-x86/arm/arm-linux-androideabi-4.6/bin/../lib/gcc/arm-linux-androideabi/4.6.x-google/../../../../arm-linux-androideabi/bin/ld: warning: hidden symbol 'oggpack_readinit' in /home/dannyliang/work/codes/b2g_flatfish_github/objdir-gecko/toolkit/library/../../media/libogg/Unified_c_media_libogg0.o is referenced by DSO /home/dannyliang/work/codes/b2g_flatfish_github/out/target/product/flatfish/obj/lib/libstagefright.so
/home/dannyliang/work/codes/b2g_flatfish_github/prebuilts/gcc/linux-x86/arm/arm-linux-androideabi-4.6/bin/../lib/gcc/arm-linux-androideabi/4.6.x-google/../../../../arm-linux-androideabi/bin/ld: warning: hidden symbol 'oggpack_read' in /home/dannyliang/work/codes/b2g_flatfish_github/objdir-gecko/toolkit/library/../../media/libogg/Unified_c_media_libogg0.o is referenced by DSO /home/dannyliang/work/codes/b2g_flatfish_github/out/target/product/flatfish/obj/lib/libstagefright.so
/home/dannyliang/work/codes/b2g_flatfish_github/prebuilts/gcc/linux-x86/arm/arm-linux-androideabi-4.6/bin/../lib/gcc/arm-linux-androideabi/4.6.x-google/../../../../arm-linux-androideabi/bin/ld: warning: hidden symbol 'vorbis_comment_clear' in /home/dannyliang/work/codes/b2g_flatfish_github/objdir-gecko/toolkit/library/../../media/libtremor/lib/tremor_info.o is referenced by DSO /home/dannyliang/work/codes/b2g_flatfish_github/out/target/product/flatfish/obj/lib/libstagefright.so
/home/dannyliang/work/codes/b2g_flatfish_github/prebuilts/gcc/linux-x86/arm/arm-linux-androideabi-4.6/bin/../lib/gcc/arm-linux-androideabi/4.6.x-google/../../../../arm-linux-androideabi/bin/ld: warning: hidden symbol 'vorbis_info_clear' in /home/dannyliang/work/codes/b2g_flatfish_github/objdir-gecko/toolkit/library/../../media/libtremor/lib/tremor_info.o is referenced by DSO /home/dannyliang/work/codes/b2g_flatfish_github/out/target/product/flatfish/obj/lib/libstagefright.so
/home/dannyliang/work/codes/b2g_flatfish_github/prebuilts/gcc/linux-x86/arm/arm-linux-androideabi-4.6/bin/../lib/gcc/arm-linux-androideabi/4.6.x-google/../../../../arm-linux-androideabi/bin/ld: error: /home/dannyliang/work/codes/b2g_flatfish_github/objdir-gecko/toolkit/library/../../dom/nfc/Unified_cpp_dom_nfc0.o: requires unsupported dynamic reloc R_ARM_REL32; recompile with -fPIC
/home/dannyliang/work/codes/b2g_flatfish_github/prebuilts/gcc/linux-x86/arm/arm-linux-androideabi-4.6/bin/../lib/gcc/arm-linux-androideabi/4.6.x-google/../../../../arm-linux-androideabi/bin/ld: error: /home/dannyliang/work/codes/b2g_flatfish_github/objdir-gecko/toolkit/library/../../dom/nfc/Unified_cpp_dom_nfc0.o: requires unsupported dynamic reloc R_ARM_REL32; recompile with -fPIC
/home/dannyliang/work/codes/b2g_flatfish_github/prebuilts/gcc/linux-x86/arm/arm-linux-androideabi-4.6/bin/../lib/gcc/arm-linux-androideabi/4.6.x-google/../../../../arm-linux-androideabi/bin/ld: error: read-only segment has dynamic relocations
/home/dannyliang/work/codes/b2g_flatfish_github/prebuilts/gcc/linux-x86/arm/arm-linux-androideabi-4.6/bin/../lib/gcc/arm-linux-androideabi/4.6.x-google/../../../../arm-linux-androideabi/bin/ld: /home/dannyliang/work/codes/b2g_flatfish_github/objdir-gecko/toolkit/library/../../dom/nfc/Unified_cpp_dom_nfc0.o: in function mozilla::dom::MozIsoDepTech::Transceive(mozilla::dom::TypedArray<unsigned char, &(js::UnwrapUint8Array(JSObject*)), &(JS_GetUint8ArrayData(JSObject*, JS::AutoCheckCannotGC const&)), &(js::GetUint8ArrayLengthAndData(JSObject*, unsigned int*, unsigned char**)), &(JS_NewUint8Array(JSContext*, unsigned int))> const&, mozilla::ErrorResult&):../../../gecko/dom/nfc/MozIsoDepTech.cpp:92: error: undefined reference to 'mozilla::dom::MozIsoDepTech::mTechnology'
/home/dannyliang/work/codes/b2g_flatfish_github/prebuilts/gcc/linux-x86/arm/arm-linux-androideabi-4.6/bin/../lib/gcc/arm-linux-androideabi/4.6.x-google/../../../../arm-linux-androideabi/bin/ld: /home/dannyliang/work/codes/b2g_flatfish_github/objdir-gecko/toolkit/library/../../dom/nfc/Unified_cpp_dom_nfc0.o: in function mozilla::dom::MozIsoDepTech::Constructor(mozilla::dom::GlobalObject const&, mozilla::dom::MozNFCTag&, mozilla::ErrorResult&):../../dist/include/nsRefPtr.h:92: error: undefined reference to 'mozilla::dom::MozIsoDepTech::mTechnology'
collect2: ld returned 1 exit status
make[6]: *** [libxul.so] Error 1
make[5]: *** [toolkit/library/target] Error 2
make[4]: *** [compile] Error 2
make[3]: *** [default] Error 2
make[2]: *** [realbuild] Error 2
make[1]: *** [build] Error 2

Comment 1

[Danny Liang [:dliang]]

Hi Dimi,
The build break might be caused by your commit for bug 916428, would you mind check this build break on flatfish? Thanks,

Comment 2

[Dimi Lee [ooo 29.03 - 07.04]]

Hi Danny,
Could you try delete objdir-gecko and rebuild again ?
I have faced the same issue but it works after clean objdir-gecko

Comment 3

[Danny Liang [:dliang]]

(In reply to Dimi Lee[:dimi][:dlee] from comment #2)
> Hi Danny,
> Could you try delete objdir-gecko and rebuild again ?
> I have faced the same issue but it works after clean objdir-gecko

It doesn't work, still build break. Please note flatfish is tablet without enable MOZ_B2G_RIL and it's ICS version with gcc 4.6.

Comment 4

[Dimi Lee [ooo 29.03 - 07.04]]

Attachment: WIP.patch

Hi Danny,
Could you help check if attached patch works ?

Comment 5

[Danny Liang [:dliang]]

(In reply to Dimi Lee[:dimi][:dlee] from comment #4)
> Created attachment 8550243 [details] [diff] [review]
> WIP.patch
> 
> Hi Danny,
> Could you help check if attached patch works ?

The patch works, thanks.

Comment 6

[Dimi Lee [ooo 29.03 - 07.04]]

remove assignee until we decide to use this solution instead of changing gcc

Comment 7

[Aus Lacroix [:aus]]

This breaks generic flame-kk builds also when using gcc 4.8.x. We should really consider fixing this as the patch is straightforward and also fixes the issue under these circumstances.

Comment 8

[Dimi Lee [ooo 29.03 - 07.04]]

Attachment: Patch v1

Comment 9

[Dimi Lee [ooo 29.03 - 07.04]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=112952fe2fa8

Comment 10

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/db595b5a2457

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/db595b5a2457