1122108 - Allow switching an add-on from Listed to Unlisted

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P2)

Description

[Wil Clouser [:clouserw]]

I think this is relatively simple compared to the reverse.  Listed add-ons won't need any review and we won't need to collect any additional information.  We should just set their status to unlisted and make sure none of their information is publicly accessible.

Comment 1

[Mathieu Agopian [:magopian]]

So, do you confirm that a listed addon that is fully reviewed will be switch to an unlisted addon that is fully reviewed?

Same for the preliminary review?

What happens with addons that aren't reviewed yet? Should we still allow those to be switched? I'm asking, because in this case, they won't have the automatic validation (if we only change the Addon.is_listed field from True to False).

I guess we could run the validator in this case to possibly automatically validate (and thus, review) them. This would only apply to addons waiting for a preliminary review though (we don't do automatic validation for full reviews).

Comment 2

[Mathieu Agopian [:magopian]]

Isn't an unlisted addon recommended to have a custom <updateURL>? Maybe we should warn the developer about that.

Comment 3

[Wil Clouser [:clouserw]]

Not allowing switching for unreviewed add-ons would be fine with me.  I'd like to avoid weird corner cases and complexity unless we need it.

I think these questions are for jorge and kris again.

Comment 4

[Kris Maglione [:kmag]]

I think we should allow switching either way. If there are versions awaiting review, they can either be disabled, or put through the normal automated validation/manual review process. Either is fine with me.

I agree that we should warn about missing update URLs.

Comment 5

[Mathieu Agopian [:magopian]]

Attachment: Screen Shot 2015-04-17 at 14.56.31.png

Comment 6

[Mathieu Agopian [:magopian]]

Attachment: Screen Shot 2015-04-17 at 14.56.44.png

Here's an attempt at formalizing the bug:

In the devhub, in the "Manage status & versions" page of an add-on, there's the "add-on visibility" block that allows the change of status between listed, hidden or unlisted (see screenshot attached).

At the moment, the "unlisted" radio button is disabled, but it should be enabled, whatever the current review status of the add-on.

Once clicked, it should display a pop-in the same way it's already done when clicking on "hidden" (see screenshot attached). This pop-in should ask confirmation, and warn about the missing custom <updateURL> in the install.rdf file, maybe with a link to https://developer.mozilla.org/en-US/Add-ons/Install_Manifests#updateURL (listed add-ons aren't allowed to have one, but unlisted may, and should, specify one). It could advise uploading a new version with a custom <updateURL> in the future.
Maybe something along those lines (wording to be adapted ;)

"""
Unlist Add-on

Unlisting your add-on will make it (and each of its versions/files) invisible on this website. It won't show up in searches, won't have a public facing page, and won't be updated automatically for current users.
It is recommended for unlisted add-ons to provide a custom <updateURL> (link to mdn) in their install.rdf file for automatic updates.

Are you sure you wish to unlist your add-on?

Unlist Add-on or Cancel
"""

Clicking on "cancel" will simply close the pop-in and not change anything. Clicking on "unlist add-on" will update the addon.is_listed field to "False", and disable the two other radio buttons (at least until bug 1122107 is implemented).

We need to make sure that once the add-on is unlisted, it's not visible anymore publicly: it may need unindexing so it doesn't appear in the searches anymore. We'll also need to (soft) delete all its user reviews (the soft deletion for user reviews is already implemented, there's a "deleted" field with a delete() and undelete() methods).

If the add-on wasn't reviewed yet, it shouldn't change anything: it should automatically appear in the relevant unlisted queue (to be checked).

Comment 7

[Jorge Villalobos [:jorgev] (he/him)]

+1 for comment #4

Comment 8

[Rob Hudson [:robhudson]]

https://github.com/mozilla/olympia/commit/d2dfe3178c3d7ed577871c5f5f90601b37d5e29b