Closed Bug 1122932 Opened 5 years ago Closed 5 years ago

[FlatFish] Upgrade toolchain version to gcc.4.8

Categories

(Firefox OS Graveyard :: General, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: _AtilA_, Assigned: _AtilA_)

References

Details

(Whiteboard: [TCP][Flatfish])

Attachments

(2 files, 1 obsolete file)

We are facing some build errores on Flatfish that can be solved by upgarding the toolchain to a newer one. Right now Flatfish is based un gcc-4.6 (Jelly Bean 4.2), and the plan is to upgrade the toolchain to gcc-4.8 (as we did with ICS devices recently)
Assignee: nobody → atilag
Whiteboard: [TCP][Flatfish]
Blocks: flatfish
Summary: [FlatFish] Upgrade toolchain to build Gecko to gcc-4.8 → [FlatFish] Upgrade toolchain version to gcc.4.8
Hi Juan,
Do you mean the build break for https://bugzilla.mozilla.org/show_bug.cgi?id=1121869 ?
I try to check the gcc neon capacity before use that.
Yes, this is fixed with gcc-4.8 (and some others related)
In Jelly Bean based systems, toolchains are downloaded to prebuilts/ directory. As we could have two different toolchains to compile Gonk and Gecko, and both are in the same directory, I modified the build system to get the most recent one found. $(wildcard /path/arm-linux-androideabi*/arm-linux-androideabi- ) get a list of directories sorted by name, so the last version should be the last in the list. $(word $(words list ), list) gets the last one.

Another approach could be putting the toolchain alone in a separated directory.
Attachment #8550873 - Flags: review?(mwu)
gerard-majax noticed that I was PRing against master. I would like to have these changes in master too, but for this bug I should PR against b2g-4.2.2_r1.
Attachment #8550873 - Attachment is obsolete: true
Attachment #8550873 - Flags: review?(mwu)
Attachment #8550890 - Flags: review?(mwu)
I still cannot build for Flatfish because of :
In file included from Unified_cpp_dom_system_gonk0.cpp:38:0:
../../../../gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp: In member function 'void GonkGPSGeolocationProvider::StartGPS()':
../../../../gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp:676:8: error: unused variable 'singleShot' [-Werror=unused-variable]
   bool singleShot = false;
        ^
In file included from Unified_cpp_dom_system_gonk0.cpp:38:0:
../../../../gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp: At global scope:
../../../../gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp:60:20: error: 'kNetworkConnStateChangedTopic' defined but not used [-Werror=unused-variable]
 static const char* kNetworkConnStateChangedTopic = "network-connection-state-changed";
Yeah, but they are tracked by bug 1121907
Have patches for them too.
Attachment #8550890 - Flags: review?(mwu) → review+
Attachment #8550874 - Flags: review?(mwu) → review+
You need to log in before you can comment on or make changes to this bug.