1122932 - [FlatFish] Upgrade toolchain version to gcc.4.8

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Juan Gomez [:_AtilA_] (CET/CEST)]

We are facing some build errores on Flatfish that can be solved by upgarding the toolchain to a newer one. Right now Flatfish is based un gcc-4.6 (Jelly Bean 4.2), and the plan is to upgrade the toolchain to gcc-4.8 (as we did with ICS devices recently)

Comment 1

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Hi Juan,
Do you mean the build break for https://bugzilla.mozilla.org/show_bug.cgi?id=1121869 ?
I try to check the gcc neon capacity before use that.

Comment 2

[Juan Gomez [:_AtilA_] (CET/CEST)]

Yes, this is fixed with gcc-4.8 (and some others related)

Comment 3

[Juan Gomez [:_AtilA_] (CET/CEST)]

Attachment: Build system now chooses the most recent toolchain version found in the same directory

In Jelly Bean based systems, toolchains are downloaded to prebuilts/ directory. As we could have two different toolchains to compile Gonk and Gecko, and both are in the same directory, I modified the build system to get the most recent one found. $(wildcard /path/arm-linux-androideabi*/arm-linux-androideabi- ) get a list of directories sorted by name, so the last version should be the last in the list. $(word $(words list ), list) gets the last one.

Another approach could be putting the toolchain alone in a separated directory.

Comment 4

[Juan Gomez [:_AtilA_] (CET/CEST)]

Attachment: Add gcc-4.8 based toolchain to the Flatfish manifest

Comment 5

[Juan Gomez [:_AtilA_] (CET/CEST)]

Attachment: Build system now chooses the most recent toolchain version found in the same directory (b2g-4.2.2_r1 branch)

gerard-majax noticed that I was PRing against master. I would like to have these changes in master too, but for this bug I should PR against b2g-4.2.2_r1.

Comment 6

[:gerard-majax]

I still cannot build for Flatfish because of :
In file included from Unified_cpp_dom_system_gonk0.cpp:38:0:
../../../../gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp: In member function 'void GonkGPSGeolocationProvider::StartGPS()':
../../../../gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp:676:8: error: unused variable 'singleShot' [-Werror=unused-variable]
   bool singleShot = false;
        ^
In file included from Unified_cpp_dom_system_gonk0.cpp:38:0:
../../../../gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp: At global scope:
../../../../gecko/dom/system/gonk/GonkGPSGeolocationProvider.cpp:60:20: error: 'kNetworkConnStateChangedTopic' defined but not used [-Werror=unused-variable]
 static const char* kNetworkConnStateChangedTopic = "network-connection-state-changed";

Comment 7

[Juan Gomez [:_AtilA_] (CET/CEST)]

Yeah, but they are tracked by bug 1121907
Have patches for them too.

Comment 8

[Juan Gomez [:_AtilA_] (CET/CEST)]

https://github.com/mozilla-b2g/platform_build/commit/8edf4aafc0c787da24cd31b09b82e861c87a8445
https://github.com/mozilla-b2g/b2g-manifest/commit/2e571288f2944a95169c1ccfecfebb97992eb48f