1123179 - [Text Selection] Email subject not scrollable

Status: VERIFIED FIXED

(Core :: DOM: Selection, defect, P2)

Description

[Teri Wen [:twen]]

### STR
0. Prerequisite: Set up an email account.
1. Open email app.
2. Tap pencil icon to compose a new email.
3. Enter a long message in subject that extends out of screen
4. Tap on subject to bring out caret
5. Drag caret left to the beginning of the line

### Actual
Caret can't scroll to the left  

### Expected
Caret scrolls to the beginning of the subject

Note: scroll to the right will auto select and auto scroll to the end of the line

### Version
Gaia-Rev        d4dac29613076bdba3cb8adc217deadb08a2ac20
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/70de2960aa87
Build-ID        20150107160220
Version         37.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150105.192724
FW-Date         Mon Jan  5 19:27:36 EST 2015
Bootloader      L1TC00011880

Comment 1

[Teri Wen [:twen]]

**Correction 
### Version
Gaia-Rev        f5b3d1b6cfa3e702033f613915ae637cb735cbfb
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/8067c111ddff
Build-ID        20150118162501
Version         37.0a2
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150118.195525
FW-Date         Sun Jan 18 19:55:36 EST 2015
Bootloader      L1TC000118D0

Comment 2

[howie [:howie]]

Hi Teri, you said the caret can't scroll to the left, is it caused by the edge gesture? The whole email app also moved to the left of the screen? Thanks.

Comment 3

[Teri Wen [:twen]]

Attachment: MOV_2498.mp4

Yes, I think it's edge gesture. I have recorded a video for better understanding. 
Please see attachment.

Comment 4

[Teri Wen [:twen]]

Email app did not move, only the scrolling did not happen. Thanks.

Comment 5

[Peter Chang[:pchang]]

Based on below log, the touchcaret will be hidden when hits the scrollable frame. This issue could be fixed after enabling touchcaret for scrollable frame.



I/PRLog   (26080): -1225604780[b6a4a080]: TouchCaret (b360a400): SyncVisibilityWithCaret:373 : SyncVisibilityWithCaret
I/PRLog   (26080): -1225604780[b6a4a080]: TouchCaret (b360a400): IsDisplayable:462 : Caret does not show in the scrollable frame!
I/PRLog   (26080): -1225604780[b6a4a080]: TouchCaret (b360a400): SetVisibility:169 : Set visibility hidden
I/PRLog   (26080): -1225604780[b6a4a080]: TouchCaret (b360a400): UpdatePositionIfNeeded:389 : UpdatePositionIfNeeded

Comment 6

[Peter Chang[:pchang]]

Attachment: bypass touchcaret visibility check inside a scrollable frame when drag mode is active

If touchcaret drag mode is active, it is possible that touchcaret becomes visible inside a scrollable frame for next frame.

Comment 7

[howie [:howie]]

Triage: feature blocker

Comment 8

[Peter Chang[:pchang]]

Attachment: bypass touchcaret visibility check inside a scrollable frame when drag mode is active

Update author name

Comment 9

[Peter Chang[:pchang]]

Try looks good.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=47bb14f4af76

Comment 10

[Peter Chang[:pchang]]

Comment on attachment 8555741 [details] [diff] [review]
bypass touchcaret visibility check inside a scrollable frame when drag mode is active

Review of attachment 8555741 [details] [diff] [review]:
-----------------------------------------------------------------

[Approval Request Comment]
Bug caused by (feature/regressing bug #):
User impact if declined: User can't scroll the text in subject filed
Testing completed: Verify the test case passed in local
Risk to taking this patch (and alternatives if risky): no risk
String or UUID changes made by this patch: none

Comment 11

[bhavana bajaj [:bajaj]]

waiting for m-c landing before considering the approval.

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8d3180c7e7cd

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8d3180c7e7cd

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/de6823a13bae

Comment 16

[Yeojin Chung [:YeojinC]]

This issue is verified fixed on Flame Master and 2.2.

Result: The subject scrolls automatically when the user moves the caret to the beginning of the line.
 
Device: Flame Master (KK, 319mb, full flash)
Build ID: 20150220010206
Gaia: e4f7c67378e33e83f88d38ddb4a6c2cabf1423c3
Gecko: 1b4c5daa7b7a
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Device: Flame 2.2 (KK, 319mb, full flash)
Build ID: 20150220002501
Gaia: ce79d35b92261e7cbfeaefebf87859ebeb0979b4
Gecko: b864abe1c6b3
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0