Closed Bug 1131421 Opened 5 years ago Closed 5 years ago

Refactoring for Android client for reading list service

Categories

(Android Background Services Graveyard :: Reading List Sync, defect)

All
Android
defect
Not set

Tracking

(firefox38 fixed)

RESOLVED FIXED
Firefox 38
Tracking Status
firefox38 --- fixed

People

(Reporter: rnewman, Assigned: rnewman)

References

Details

Attachments

(3 files)

Early parts of Bug 1117830, involving some refactoring and stubbing out SyncAdapters.
Depends on: 1123377
Attached file Part 1. (Pull req.)
Attachment #8561809 - Flags: review?(nalexander)
This is the code that ends up in fx-team.
Attachment #8561810 - Flags: review?(nalexander)
Build completed.

readinglist_syncadapter.xml is unconditionally packaged into the build; testing now whether that's a problem, given that the class is not.
Shipping the readinglist_syncadapter.xml doesn't seem to hurt anything.
(In reply to Richard Newman [:rnewman] from comment #4)
> Build completed.
> 
> readinglist_syncadapter.xml is unconditionally packaged into the build;
> testing now whether that's a problem, given that the class is not.

Hmm, it's not a problem since the actual connection is made, I believe, by the android:metadata attached to the <service>.  I wish this was better :/
Yeah, me too. But I don't really want to hack up our XML packaging stuff.
Comment on attachment 8561809 [details] [review]
Part 1. (Pull req.)

A few notes on GH.
Attachment #8561809 - Flags: review?(nalexander) → review+
Comment on attachment 8561810 [details] [diff] [review]
Part 1: initial stub reading list service and SyncAdapter. (Import.) v1

Review of attachment 8561810 [details] [diff] [review]:
-----------------------------------------------------------------

This was the output of fennec-copy-code.sh, right?  rs.
Attachment #8561810 - Flags: review?(nalexander) → review+
Comment on attachment 8561811 [details] [diff] [review]
Part 2: build changes to support RL service code. v1

Review of attachment 8561811 [details] [diff] [review]:
-----------------------------------------------------------------

The previous part might fail with this applied afterwards but it's not worth moving it forward.
Attachment #8561811 - Flags: review?(nalexander) → review+
https://hg.mozilla.org/mozilla-central/rev/1d374c27ade1
https://hg.mozilla.org/mozilla-central/rev/b8fa35d8bc9a
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 38
Component: Core → Reading List Sync
You need to log in before you can comment on or make changes to this bug.