1131421 - Refactoring for Android client for reading list service

Status: RESOLVED FIXED

(Android Background Services Graveyard :: Reading List Sync, defect)

Description

[Richard Newman [:rnewman]]

Early parts of Bug 1117830, involving some refactoring and stubbing out SyncAdapters.

Comment 1

[Richard Newman [:rnewman]]

Attachment: Part 1. (Pull req.)

Comment 2

[Richard Newman [:rnewman]]

Attachment: Part 1: initial stub reading list service and SyncAdapter. (Import.) v1

This is the code that ends up in fx-team.

Comment 3

[Richard Newman [:rnewman]]

Attachment: Part 2: build changes to support RL service code. v1

Comment 4

[Richard Newman [:rnewman]]

Build completed.

readinglist_syncadapter.xml is unconditionally packaged into the build; testing now whether that's a problem, given that the class is not.

Comment 5

[Richard Newman [:rnewman]]

Shipping the readinglist_syncadapter.xml doesn't seem to hurt anything.

Comment 6

[Nick Alexander :nalexander [he/him]]

(In reply to Richard Newman [:rnewman] from comment #4)
> Build completed.
> 
> readinglist_syncadapter.xml is unconditionally packaged into the build;
> testing now whether that's a problem, given that the class is not.

Hmm, it's not a problem since the actual connection is made, I believe, by the android:metadata attached to the <service>.  I wish this was better :/

Comment 7

[Richard Newman [:rnewman]]

Yeah, me too. But I don't really want to hack up our XML packaging stuff.

Comment 8

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8561809 [details] [review]
Part 1. (Pull req.)

A few notes on GH.

Comment 9

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8561810 [details] [diff] [review]
Part 1: initial stub reading list service and SyncAdapter. (Import.) v1

Review of attachment 8561810 [details] [diff] [review]:
-----------------------------------------------------------------

This was the output of fennec-copy-code.sh, right?  rs.

Comment 10

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8561811 [details] [diff] [review]
Part 2: build changes to support RL service code. v1

Review of attachment 8561811 [details] [diff] [review]:
-----------------------------------------------------------------

The previous part might fail with this applied afterwards but it's not worth moving it forward.

Comment 11

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/1d374c27ade1
https://hg.mozilla.org/integration/fx-team/rev/b8fa35d8bc9a

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1d374c27ade1
https://hg.mozilla.org/mozilla-central/rev/b8fa35d8bc9a