1123916 - [e10s] Flash plugin does not draw with dom.ipc.plugins.asyncInit = true

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[David Parks [:handyman]]

Bug 1121735 reported a crash in flash plugins with dom.ipc.plugins.asyncInit set to true.  The crash seems to have vanished in the latest build but now flash movies display as a blank window.

Formally,
STR:
0. Set dom.ipc.plugins.asyncInit=true and restart browser.
1. Open e10s window.
2. Go to a flash movie (e.g. http://www.fastswf.com/bcXRPyc )

Expected Result
---
The flash movie plays


Actual Result
---
A white window is shown where the flash movie would be.

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

From looking in the devtools I see the stream for the SWF file being opened but not read. This tells me that the result of the NPP_NewStream call has not been returned to the content process.

Comment 2

[(No longer employed by Mozilla) Aaron Klotz]

Hmmm, everything on the plugin side is working correctly.

I think that there might be a problem with resuming the HTTP channel on the e10s side of things.

Comment 3

[(No longer employed by Mozilla) Aaron Klotz]

Definitely specific to Mac. I can't reproduce this on Windows.

Comment 4

[(No longer employed by Mozilla) Aaron Klotz]

Attachment: Ensure plugin entry points are set correctly on MacOS when both asyncInit and e10s are both on

Normally SetPluginFuncs is called in different locations on Mac and Windows. When asyncInit and e10s are both on, however, those differences are handled elsewhere; it must be called at the same place on both platforms in this case.

Comment 5

[(No longer employed by Mozilla) Aaron Klotz]

The reason that this was causing failures on Mac was that async init was never replacing the PluginAsyncSurrogate entry points with the correct PluginModuleParent entry points on MacOS. The stream containing the SWF file would be permanently suspended because calls to NPP_WriteReady would permanently return 0.

Comment 6

[(No longer employed by Mozilla) Aaron Klotz]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f6795c8f0f31

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f6795c8f0f31