1124216 - Select input chooser popup sometimes ends up under other content

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

STR, on a Flame-kk device running master.
1. Ensure wi-fi and cell connections are disabled
2. Start the browser and start entering a URL in the URL bar
3. Directly under the URL bar you should get a little settings icon with the message "No internet connection"
4. Tap on the settings icon (you have to tap very precisely on the icon, it seems like tapping on the text doesn't do anything). This should open a settings screen with just the "network & connectivity" items.
5. Select "Wi-Fi"
6. Turn on the Wi-Fi toggle to expose the advanced settings, and then click on "Manage networks"
7. Click on "Join Hidden Network"
8. On the screen to add a hidden network, there is a dropdown menu under "Security". Click on it

Expected:
A screen shows the options in the menu

Actual:
The dropdown does not appear

9. Now, hit the power button to lock the device (or let the screen timeout do it)
10. Hit the power button again to turn on the screen, and unlock the device.

Expected:
Something reasonable

Actual:
The dropdown menu which was supposed to appear in step 8 is now visible. Hitting OK on this menu takes you directly back to the browser instead of the settings screen that you were on before.


Adding qawanted for branch checks. I reproduced this on master but it probably happens on older branches too.

Comment 1

[Shine(Leave from Mozilla)]

Attachment: Flame2.0 video

Hi Kartikaya,
This problem cannot be repro on latest build of Woodduck2.0 and Flame2.0/2.1/2.2.
See attachment: Flame2.0_video.MP4
Rate: 0/5

Woodduck 2.0 build:
Gaia-Rev        cf7580c3e1dcbf2ddcb56f0a30af8f85fdbc18ff
Gecko-Rev       56fc49a3478194e7c48b9e78c51312616b626009
Build-ID        20150122050313
Version         32.0
Device-Name     jrdhz72_w_ff
FW-Release      4.4.2
FW-Incremental  1421874331
FW-Date         Thu Jan 22 05:05:50 CST 2015

Flame 2.0 build:
Gaia-Rev        736933b25ded904f0cb935a0d48f1f3cf91d33ad
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/6a7c0eba2aa3
Build-ID        20150121000258
Version         32.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150121.032141
FW-Date         Wed Jan 21 03:21:51 EST 2015
Bootloader      L1TC000118D0

Flame 2.1 build:
Gaia-Rev        77c57eb8a985d5cbd34a597fb1b978ba6e205af6
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/4c28bb3be0c6
Build-ID        20150121001510
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20150121.034530
FW-Date         Wed Jan 21 03:45:41 EST 2015
Bootloader      L1TC000118D0

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Thanks, Shine! I noticed you didn't post 2.2 build info so I retested on 2.2, and was able to reproduce there.

Comment 3

[howie [:howie]]

qawanted to test if this happens in 2.2 since comment 1 didn't provide the 2.2 build informaiton

Comment 4

[Brogan Zumwalt [Inactive]]

Issue DOES occur on Flame 2.2

Security drop-down does not appear when tapped on the Join Hidden Network, unless user powers off screen then powers back on screen.

Device: Flame 2.2
Build ID: 20150123002505
Gaia: 237008137f6d72b9cad25ff4faff14ff2c40ac63
Gecko: be24dd482a83
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2)
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 5

[howie [:howie]]

Triage: regression, blocking, can we have regression window here? thanks

Comment 6

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

The changes in bug 1007600 seem to have caused this issue.

B2g-inbound Regression Window

Last Working 
Environmental Variables:
Device: Flame 2.2
BuildID: 20141020205719
Gaia: e09e1734ad523cf63351a28f6f84454319349fbe
Gecko: 4da1f6a151d6
Version: 36.0a1 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

First Broken 
Environmental Variables:
Device: Flame 2.2
BuildID: 20141020214218
Gaia: ba10744d64411a8a12ae68f7cf1ec3e3ac897d21
Gecko: bcc5df613d83
Version: 36.0a1 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Last Working gaia / First Broken gecko - Issue does NOT occur 
Gaia: e09e1734ad523cf63351a28f6f84454319349fbe
Gecko: bcc5df613d83

First Broken gaia / Last Working gecko - Issue DOEs occur
Gaia: ba10744d64411a8a12ae68f7cf1ec3e3ac897d21
Gecko: 4da1f6a151d6

Gaia Pushlog: https://github.com/mozilla-b2g/gaia/compare/e09e1734ad523cf63351a28f6f84454319349fbe...ba10744d64411a8a12ae68f7cf1ec3e3ac897d21

Comment 7

[KTucker [:KTucker][Inactive 3/4/2016]]

Arthur, can you take a look at this please? Looks like the work done on bug 1007600 might have caused this.

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

Alive, the window for value selector seems under inline activity as what I showed you yesterday, any ideas?

Comment 9

[(inactive after 6/18) Alive Kuo [:alive]]

Taken but for now I am not sure how risky this patch is.
The proposed fix is make SystemDialogManager able to listen to 'launchactivity' event before rocketbar + appWindowManager get the event, and have System be able to launch an ActivityWindow inside it.

Maybe we need to change BaseUI a lot..

Comment 10

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #9)
> Taken but for now I am not sure how risky this patch is.
> The proposed fix is make SystemDialogManager able to listen to
> 'launchactivity' event before rocketbar + appWindowManager get the event,
> and have System be able to launch an ActivityWindow inside it.
> 
> Maybe we need to change BaseUI a lot..

Correction: this issue is talking about we should let Rocketbar be able to get ValueSelector events.

Comment 11

[GitHub Autolander Bot]

Attachment: [PullReq] alivedise:buzilla/1124216/activity-window-in-system-dialog to mozilla-b2g:master

Comment 12

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8557732 [details] [review]
[PullReq] alivedise:buzilla/1124216/activity-window-in-system-dialog to mozilla-b2g:master

This also fixes bug 1117970.

Comment 13

[Kevin Grandon :kgrandon]

Comment on attachment 8557732 [details] [review]
[PullReq] alivedise:buzilla/1124216/activity-window-in-system-dialog to mozilla-b2g:master

The code seems fine to me. Thank you!

Comment 14

[(inactive after 6/18) Alive Kuo [:alive]]

https://github.com/mozilla-b2g/gaia/commit/20ed543ce08d6e594d7bc692c0f9473e12cc4e7d

Comment 15

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8557732 [details] [review]
[PullReq] alivedise:buzilla/1124216/activity-window-in-system-dialog to mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
Regression from bug 1007600 - Settings app supports inline activity.
I tend to think it's not a regression but revealed by the change - rocketbar is not expected to have value selector before.
[User impact] if declined:
User cannot select the wifi type when setting network from rocketbar.
[Testing completed]: Y
[Risk to taking this patch] (and alternatives if risky): Riskless - what we did is sent the value selector event from current app window to the search window.
[String changes made]: NaN

Comment 16

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/a21665ad1bef031a139a5912f8e6719e40c51890

Comment 17

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed on the latest Nightly Flame 3.0 and 2.2 builds.

Results: Popups show up as expected.

Environmental Variables:
Device: Flame 3.0
BuildID: 20150206010204
Gaia: 94af4b42d2ace6c9f38f31de77240604fac68af1
Gecko: 7c5f187b65bf
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0


Environmental Variables:
Device: Flame 2.2
BuildID: 20150206002505
Gaia: a52999ce7f783177deb17e267bf003a53e6fde06
Gecko: 01446d5231ef
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0