1124515 - Verify the TabsLayoutContainer height is correctly determined

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

In the work for bug 1110555, I discovered DisplayMetrics.heightPixels does not return the actual height of the display but rather the height minus some of the system status bars. In that bug, I added `HardwareUtils.getDeviceDimensions` which is the best guess to calculate the physical screen size.

We use DisplayMetrics.heightPixels to get the TabsLayoutContainer height [1]. This may have caused two bugs in the past (bug 1100317 and bug 1109155).

Verify that this value is being used correctly and if not, fix it!

It seems to be working correctly for new tablet v1 so we're only going to worry about it for v2.

[1]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/tabs/TabsPanel.java?rev=7bbe830c1e88#256

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Note that bug 1104133 states that the height is incorrect - perhaps more information can be gleamed from that bug.

Comment 3

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.