1125411 - Enable OS X CoreLocation provider

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Comment 1

[:garvan]

Attachment: enable-corelocation-by-default.diff

Changed the default to enabled.

Comment 2

[Chris Peterson [:cpeterson]]

Comment on attachment 8554556 [details] [diff] [review]
enable-corelocation-by-default.diff

Review of attachment 8554556 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM. Do you plan to enable CoreLocation before or after you land the MLS GeoIP fallback (bug 1121265)?

It would be nice if the "geo.provider.use_corelocation" pref was defined in browser/app/profile/firefox.js. That way it will show up in about:config and people can toggle it without needing to know some secret pref name.

Comment 3

[:garvan]

bug 1121265 (and before that, bug 1121497) should land first.

I like your point about exposing the pref, let's do that, it is more user friendly (for the enthusiast user who likes to play in about:config).

Comment 4

[:garvan]

Attachment: enable core location by default and expose in about:config

Added: expose the corelocation pref to about:config

Comment 5

[:garvan]

Comment on attachment 8554624 [details] [diff] [review]
enable core location by default and expose in about:config

Hold on, lets wrap that firefox.js line in mac-only, since I just found an example of that.

Comment 6

[:garvan]

Attachment: enable-corelocation-by-default.diff

Added mac-only pref to firefox.js

Comment 7

[Chris Peterson [:cpeterson]]

Comment on attachment 8554631 [details] [diff] [review]
enable-corelocation-by-default.diff

Review of attachment 8554631 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

Comment 8

[:garvan]

Attachment: enable-corelocation-by-default.diff

Rebased on latest m-c. Carry over r+ from cpeterson.
Try green:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=50f3f704e0d3

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/32fe616d4950

Comment 10

[Carsten Book [:Tomcat]]

sorry had to back out this changes in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=e28ef6984108 since one of this changes caused a bustage in  OS X static analysis builds like:

https://treeherder.mozilla.org/logviewer.html#?job_id=5955163&repo=mozilla-inbound

Comment 11

[:garvan]

Bug 1121265 was the problem patch, is fixed

Comment 12

[Jean-Yves Perrier [:teoli]]

I'm trying to evaluate documentation needs here: will this have an impact on Geolocation API? I guess it will improve accuracy on OS X.

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ca80c9cad184

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ca80c9cad184

Comment 15

[:garvan]

No impact on the Geolocation API is intended. 
Regarding accuracy: previously the Google location service was being used, the switch to Apple's service may produce different results, but both services are considered to have equivalent accuracy.

Comment 16

[Liz Henry (:lizzard) (relman/hg->git project)]

https://hg.mozilla.org/projects/holly/rev/740907c7d4ca