URLBar shouldn't be handling keyword searches itself when UnifiedComplete is enabled

RESOLVED FIXED in Firefox 52

Status

()

Firefox
Location Bar
P4
normal
Rank:
45
RESOLVED FIXED
3 years ago
6 months ago

People

(Reporter: Unfocused, Unassigned)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 52
Points:
3
Dependency tree / graph
Bug Flags:
firefox-backlog +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [unifiedautocomplete][fxsearch])

When hitting enter after typing something in the URLBar, we end up calling _canonizeURL(), which in turn calls getShortcutOrURIAndPostData() - this looks up keyword searches. With UnifiedComplete enabled, this should entirely be handled by UnifiedComplete. The only processing the URLBar binding should be doing is handling moz-action URIs and adding the right suffixes (the later of which would be nice to move into UnifiedComplete also).
Flags: qe-verify+
Flags: firefox-backlog+
Whiteboard: [fxsearch][unifiedautocomplete]
Priority: -- → P4

Updated

2 years ago
Rank: 45
Whiteboard: [fxsearch][unifiedautocomplete] → [unifiedautocomplete][fxsearch]
This is more a code cleanup thing than a bug needed for unified complete.
I also don't think we can do this before we stop allowing to disable unified complete, it would just make the code more complicated.
Blocks: 1071461
No longer blocks: 995091
Depends on: 1169985, 995091

Updated

10 months ago
Depends on: 1310737

Comment 2

10 months ago
bug 1310737 has completed the inversion of behavior where now the awesomebar decides what to load, rather than the docshell (apart a single case where the docshell may try to resolve a domain and then fallback to a search).
We now pass through getShortcutOrURI only in legacy testing code and add-ons, but the normal flow won't go through it, so we don't run twice the code figuring out if something is a keyword or an alias.
Status: NEW → RESOLVED
Last Resolved: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Removing the keyword since this bug doesn't have a patch and bug 1310737 was verified.
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.