Closed
Bug 1126438
Opened 11 years ago
Closed 11 years ago
MIR.h:5540:10 [-Winconsistent-missing-override] 'canClone' overrides a member function but is not marked 'override'
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
RESOLVED
FIXED
mozilla38
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
1.45 KB,
patch
|
Details | Diff | Splinter Review |
Build warnings with clang 3.6:
{
js/src/jit/MIR.h:5540:10 [-Winconsistent-missing-override] 'canClone' overrides a member function but is not marked 'override'
js/src/jit/MIR.h:5544:19 [-Winconsistent-missing-override] 'clone' overrides a member function but is not marked 'override'
}
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8555420 -
Flags: review?(jdemooij)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 8555420 [details] [diff] [review]
1126438-fix.patch
Actually, ehsan granted me blanket-r+ on fixes of this sort over in bug 1126447, so I won't waste your time getting review on this. :)
Attachment #8555420 -
Flags: review?(jdemooij)
|
|
Assignee | |
Comment 3•11 years ago
|
||
Flags: in-testsuite-
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in
before you can comment on or make changes to this bug.
Description
•