Closed Bug 1126438 Opened 5 years ago Closed 5 years ago

MIR.h:5540:10 [-Winconsistent-missing-override] 'canClone' overrides a member function but is not marked 'override'

Categories

(Core :: JavaScript Engine: JIT, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla38

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Build warnings with clang 3.6:
{
js/src/jit/MIR.h:5540:10 [-Winconsistent-missing-override] 'canClone' overrides a member function but is not marked 'override'
js/src/jit/MIR.h:5544:19 [-Winconsistent-missing-override] 'clone' overrides a member function but is not marked 'override'
}
Attachment #8555420 - Flags: review?(jdemooij)
Comment on attachment 8555420 [details] [diff] [review]
1126438-fix.patch

Actually, ehsan granted me blanket-r+ on fixes of this sort over in bug 1126447, so I won't waste your time getting review on this. :)
Attachment #8555420 - Flags: review?(jdemooij)
https://hg.mozilla.org/mozilla-central/rev/8c4a67f63f9b
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla38
You need to log in before you can comment on or make changes to this bug.