1127080 - make platform filter persist site-wide

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect, P3)

Description

[David Bialer [:dbialer]]

Currently there is a bug in that the platform selection persists between New and Popular tabs, but shouldn't, as it is inconsistent with other pages (search, categories, etc - do not persist across pages).  However, I think this is the correct behavior.

This bug is actually to change other behavior to persist the platform selector across pages, but not between sessions.  I think it behaves the exact opposite of this.

The reason is that if a person selects a platform on Popular page - say Desktop, chances are that if they go to another page, or perform a search, they want to stay in that context of looking for Desktop apps.

To summarize.
1. Persist platform selector across Marketplace within a session.
2. Do not persist between sessions.

Comment 1

[sdevaney]

+1

Comment 2

[Mathieu Pillard [:mat]]

For the record, this is indeed the correct behaviour, it was done on purpose. But I agree that your way is better.

Comment 3

[David Durst [:ddurst]]

I don't think the user should have to set that with every new session. Once they've decided, they've decided.

However, I do agree that per-page gets weird.

This is not something we are going to change as part of the desktopUI launch, though.

Comment 4

[David Durst [:ddurst]]

This was discussed last night. Verdict:

On desktop:
1. For now, implement platform filter on homepage and feed pages.
2. The default should be Desktop Apps.
3. Any user selection should persist only for that session, and only for that page.

Comment 5

[sdevaney]

I want to make sure I understand point #3:

3. Any user selection should persist only for that session, and only for that page.

... this says to me that if, for example, you are on desktop and you want to see "All Apps" and you select that on the Games category page, then you navigate over the Utilities page, you have to again select "All Apps" and then if you navigate to the Music category, you again have to select "All Apps". In other words, if the purpose of this particular session is to browse "All Apps" I have to manually select it on every page I visit. Is this what we're doing?

Comment 6

[David Durst [:ddurst]]

That's what we're doing *for now*, while this is our (page-based) UI.

The goal is to turn around and revise the nav AND redesign this control to be sitewide.

Whether this sees the light of day will be determined in the program meeting.

Comment 7

[Kevin Ngo [:ngoke]]

I think platform filtering work will be separate from desktop UI work, so removing it from the tracker.

Comment 8

[Kevin Ngo [:ngoke]]

I am working on this now since this blocks tracking for Device Filtering.

Comment 9

[David Durst [:ddurst]]

Pretty sure this is supposed to be site-wide and across sessions. Liz?

Comment 10

[Elizabeth Hunt[:ezoehunt]]

Yup site wide. Will update PRD.

Comment 11

[Kevin Ngo [:ngoke]]

https://github.com/mozilla/fireplace/pull/1057
https://github.com/mozilla/fireplace/pull/1066

STR:

1. Open up New page.
2. Change the platform selector dropdown to something else (e.g, "All apps")
3. Go to Popular page.
4. Refresh the page.

Expected:

Your selection should persist after you go to the Popular page and after you refresh the page.

Comment 12

[Victor Carciu]

Verified as fixed : http://screencast.com/t/zVSXJSka

Comment 13

[Kevin Ngo [:ngoke]]

https://github.com/mozilla/fireplace/pull/1194