1127658 - [Messages] Caret shown in Options -> on top of Settings button

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Eric Chang [:ericcc] [:echang]]

Attachment: 2015-01-30-09-10-26.png

*** Steps to Reproduce
1. Empty messages, no mail thread
2. Tap 3 dots to options
NEED STR

*** Expected Results
Caret not shown

*** Actual Results
Caret shown on "Settings"

*** Reproduction Frequency: 10%

*** Version
Serial: e47cd843 (State: device)
Build ID               20150129003432
Gaia Revision          6e494f1d2676d231abba7dcc2e2822d1170d2d02
Gaia Date              2015-01-29 06:34:56
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/5e6fac01a72f
Gecko Version          37.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150129.042943
Firmware Date          Thu Jan 29 04:29:53 EST 2015
Bootloader             L1TC000118D0

Comment 1

[jlorenzo (disabled)]

Triage: Broken new functionality.

Comment 2

[Eric Chang [:ericcc] [:echang]]

Attachment: 2015-01-30-12-23-48.png

Comment 3

[Eric Chang [:ericcc] [:echang]]

Messages empty
1. Tap 3 dots to options, only "Settings" there.
2. Tap & slide  the small space between left border and the " Settings         " button and slide to the right. (but not to highlight the button)

Messages not empty, with mail threads
1. Tap 3 dots to options, "Select Threads", "Settings" there.
2. Tap & slide  the small space between left border and the " Select Threads       " button and slide to the right. (but not to highlight the button)

Comment 4

[Noemí Freire (:noemi)]

Also occurring in master so marking "status-b2g-v3.0" as affected.

Environmental variables:
Flame 3.0 device
Build Id: 20150130082956
Gecko: 8e96000
Gaia: 21829dd
Platform version: 38.0a1

Comment 5

[GitHub Autolander Bot]

Attachment: Link to github

Comment 6

[Steve Chung [:steveck]]

Comment on attachment 8562670 [details] [review]
Link to github

Hi Oleg, since bug 1129356 landed, now we can apply user-select none to root html element(main-wrapper panel is absolute positioned element). In the meantime we don't use universal selector to apply user-selector to all the elements, it should be able to inherit from html element after bug 1129356 landed.

Comment 7

[Oleg Zasypkin [:azasypkin][⏰UTC+1]]

Comment on attachment 8562670 [details] [review]
Link to github

Looks good to me, thanks!

Comment 8

[Steve Chung [:steveck]]

Thanks!

In master: https://github.com/mozilla-b2g/gaia/commit/2fcc32b3dca792b7ce43d16aaa504fe41b4899db

Comment 9

[Steve Chung [:steveck]]

Comment on attachment 8562670 [details] [review]
Link to github

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):Bug 1092437 (text selection feature)
[User impact] if declined: String in option menu will become selectable. 
[Testing completed]: N/A
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: N/A

Comment 10

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/dfce54a79fb52eb7ce58d910f077b4a2e808ea7f

Comment 11

[Pi Wei Cheng [:piwei] (inactive)]

Important prerequisite to STR at comment 3: Turn off Edge Gesture.
I was having trouble reproducing this bug on an 1/29 central build because I had edge gesture turned on. (by default it is turned on)

------

This issue is verified fixed on Flame 3.0 and 2.2. Long pressing on the space between Messages Settings and left edge of the phone does not bring up a caret/waterdrop icon.

Device: Flame 3.0
BuildID: 20150406010204
Gaia: ef61ebbe5de8c2c9fc2a8f74a12455044c3b82e9
Gecko: 4fe763cbe196
Gonk: b83fc73de7b64594cd74b33e498bf08332b5d87b
Version: 40.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

Device: Flame 2.2
BuildID: 20150406002503
Gaia: a6351e1197d54f8624523c2db9ba1418f2aa046f
Gecko: c3335a5d3063
Gonk: ebad7da532429a6f5efadc00bf6ad8a41288a429
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0