1129356 - Absolute child element should not be selectable if parent has -moz-user-select: none

Status: RESOLVED FIXED

(Core :: DOM: Selection, defect)

Description

[(Inactive after June) George Duan [:gduan] [:喬智]]

Follow-up bug of https://bugzilla.mozilla.org/show_bug.cgi?id=1127587#c7

Elements with absolute position should not be selectable if parent has -moz-user-select:none attribute.

See https://everlong.org/mozilla/testcase-user-select/ .

Comment 1

[Julien Wajsberg [:julienw]]

Attachment: testcase-user-select.html

attaching the testcase for posterity (but having it online is easier for B2G)

Comment 2

[Julien Wajsberg [:julienw]]

Asking to block for 2.2 because otherwise we'll need workaround in all apps (not to mention the content we don't control).

Comment 3

[Mats Palmgren (inactive)]

Attachment: Traverse the placeholder's parent for abs.pos. frames when determining the used value for 'user-select'.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=21c4541490ae

Other tests passed in an earlier run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6278fb4d20ff

Comment 4

[Mats Palmgren (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/20e294d67bf2

Comment 5

[Julien Wajsberg [:julienw]]

Please don't forget to ask an approval for Firefox OS v2.2. Thanks !

Comment 6

[Mats Palmgren (inactive)]

(In reply to Julien Wajsberg [:julienw] from comment #5)
> Please don't forget to ask an approval for Firefox OS v2.2. Thanks !

One of the b2g* flags I presume - but which flag is it exactly?

Comment 7

[Julien Wajsberg [:julienw]]

Yeah, it's b2g37.
These days Aurora will also get merged there, so if you think this is worth uplifting to aurora, this is also a possibility.

Comment 8

[Mats Palmgren (inactive)]

Comment on attachment 8561036 [details] [diff] [review]
Traverse the placeholder's parent for abs.pos. frames when determining the used value for 'user-select'.

Approval Request Comment
[Feature/regressing bug #]: -
[User impact if declined]: some elements will be selectable/not selectable when not intended by the page author
[Describe test coverage new/current, TreeHerder]: added a test, green on m-i
[Risks and why]: zero risk, simple one-liner
[String/UUID change made/needed]: none

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/20e294d67bf2

Comment 10

[Julien Wajsberg [:julienw]]

Hey Bhavana, do you know who gives aurora approvals ?

Comment 11

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

ni to howie. this is blocking copy-and-paste?
Could you please triage this?

Comment 12

[howie [:howie]]

This one should be blocking. Thanks everyone for the help.

Comment 13

[Lawrence Mandel [:lmandel] (use needinfo)]

Comment on attachment 8561036 [details] [diff] [review]
Traverse the placeholder's parent for abs.pos. frames when determining the used value for 'user-select'.

One liner + a test. Aurora+

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/0b04653c3d81

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/0b04653c3d81