1129592 - MozReview should be better at suggesting reviewers in the autocomplete popup

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect, P3)

Description

[Mike Conley (:mconley) (:⚙️)]

From IRC:

14:42 (Mossop) mconley: The new way of choosing reviewers in reviewboard seems to be more confusing than before. I don't recall the old autocomplete popup for names showing so much junk
14:43 (mconley) Mossop: ah, can you elaborate on this junk?
14:44 (Mossop) mconley: e.g. if I type felipe in an autocomplete popup up appear showing maybe 20 or 30 names with felipe in them, lots of random numbers etc. None of them the actual felipe I want
14:44 (mconley) Mossop: what do you get when you type "felipe" into a field in Bugzilla?
14:46 (Mossop) mconley: Much better looking options, including the real one. Crucially in bugzilla I can type ":felipe" and get exactly what I want, but the autocomplete on rb seems to just ignore the :
14:48 (nalexander) Mossop: mconley: I see this too, including strange "gps125456" entries.

Comment 1

[Gregory Szorc [:gps]]

Can we not show users that don't have the :ircnick syntax? Or would this exclude legitimate entries? What about surfacing :ircnick matches so they are first in the results?

Comment 2

[Mark Côté [:mcote]]

See also other autocomplete bugs: bug 1087740, bug 1123458.

Comment 3

[:Gijs (he/him)]

How does one get something like this prioritized?

I just spent a full minute trying to select Margaret as a reviewer for my patch in bug 1147337. You see, if you just put in "margaret", then you get a gazillion hits. If you put in ":margaret", you seem to get nothing (?). If you put in "margaret.leibovic", which happens to be a substring of her email address, you get exactly one autocomplete item but hitting tab (as the dropdown suggests!) or clicking the autocomplete item just results in no reviewer being selected. I don't know why.

I couldn't find a way to make this work except by removing ".leibovic" and then *quickly* clicking the item I wanted so that it autocompleted the right thing and didn't refresh causing me to select some poor unknown person who maybe filed a bug here once. This took several tries.

Can we please please please get this fixed? Bugzilla's review flag picker at least Just Works.

Comment 4

[Gregory Szorc [:gps]]

I'm able to reproduce. The issue is annoying, for sure.

Raising priority to P1.

Comment 6

[Mark Côté [:mcote]]

Also, from dustin in bug 1167628: "Amy Rich [:arich] [:arr] autocompletes from 'arich', but not from 'arr'."  Note this is about autocomplete, not username, which in this case will be "arich".

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

Maybe I shouldn't have said "autocomplete" there.  Entering "arr" and hitting return gives an error.

Sorry if that was already clear.

Comment 8

[Mark Côté [:mcote]]

Ah, yeah, that's because you're using the username when you just type and hit enter.  We pick the username from the real name field by :<nick> convention.  Since you can only have one username, we go with the first one that's hit.  Maybe Amy should change the order in her name, since she's known a lot more as "arr" than "arich". :) (Review Board will automatically adjust the username if she does this change in BMO.)

Comment 10

[Mark Côté [:mcote]]

After removing most users from the database, this seems a lot more manageable.  I'm not sure if this is considered fixed yet, but I think it's worth lowering in priority compared to other UI issues and workflow papercuts.  Please shout if you disagree (bearing in mind all the other things to improve :)

Comment 11

[Mark Côté [:mcote]]

I haven't heard any other complaints specifically about this, so I'm going to close it out.