Closed Bug 1130938 Opened 5 years ago Closed 5 years ago

B2G RIL: Remove the duplicated RilWorkerBuffer in ril_worker.js

Categories

(Firefox OS Graveyard :: RIL, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(firefox38 fixed)

RESOLVED FIXED
Tracking Status
firefox38 --- fixed

People

(Reporter: gweng, Assigned: gweng)

References

Details

Attachments

(2 files)

+++ This bug was initially created as a clone of Bug #1123066 +++

Since in Bug 1123066 I did the wrong rebasing so the code still in ril_worker.js, while there is the new, independent ril_worker_buffer.js file. So in this bug I need to remove them from the ril_worker.js.
Oh, sorry, cloning bug indicates to the wrong bug. The Bug should be Bug 1123201. This is because it's another cloned bug, too.
Blocks: 1123066
No longer depends on: 1123066, 1123201
Blocks: 1123201
No longer blocks: 1123066
The try is green:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=60587bb96c08

I'll submit the patch and set the review flag.
Attached patch PatchSplinter Review
Patch: remove the duplicated code.
Comment on attachment 8561318 [details] [diff] [review]
Patch

Follow the first bug, set :aknow as the reviewer.
Attachment #8561318 - Flags: review?(szchen)
Assignee: nobody → gweng
Blocks: 1113054
Comment on attachment 8561318 [details] [diff] [review]
Patch

Review of attachment 8561318 [details] [diff] [review]:
-----------------------------------------------------------------

((Stealing the review ... ))

Thank you, Greg.
Attachment #8561318 - Flags: review?(szchen) → review+
Attached patch Patch rev2Splinter Review
I've updated the patch to rebase it and add new review message.
Keeping the old patch to show the review flag is +.
https://hg.mozilla.org/mozilla-central/rev/84ddb2bacfc0
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Blocks: 1146799
No longer blocks: 1146799
Blocks: 811754
You need to log in before you can comment on or make changes to this bug.