B2G RIL: Remove the duplicated RilWorkerBuffer in ril_worker.js

RESOLVED FIXED

Status

Firefox OS
RIL
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: snowmantw, Assigned: snowmantw)

Tracking

(Blocks: 1 bug)

unspecified
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(firefox38 fixed)

Details

Attachments

(2 attachments)

+++ This bug was initially created as a clone of Bug #1123066 +++

Since in Bug 1123066 I did the wrong rebasing so the code still in ril_worker.js, while there is the new, independent ril_worker_buffer.js file. So in this bug I need to remove them from the ril_worker.js.
(Assignee)

Comment 1

3 years ago
Oh, sorry, cloning bug indicates to the wrong bug. The Bug should be Bug 1123201. This is because it's another cloned bug, too.
(Assignee)

Updated

3 years ago
Blocks: 1123066
No longer depends on: 1123066, 1123201
(Assignee)

Updated

3 years ago
Blocks: 1123201
No longer blocks: 1123066
(Assignee)

Comment 2

3 years ago
The try is green:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=60587bb96c08

I'll submit the patch and set the review flag.
(Assignee)

Comment 3

3 years ago
Created attachment 8561318 [details] [diff] [review]
Patch

Patch: remove the duplicated code.
(Assignee)

Comment 4

3 years ago
Comment on attachment 8561318 [details] [diff] [review]
Patch

Follow the first bug, set :aknow as the reviewer.
Attachment #8561318 - Flags: review?(szchen)
(Assignee)

Updated

3 years ago
Assignee: nobody → gweng

Updated

3 years ago
Blocks: 1113054

Comment 5

3 years ago
Comment on attachment 8561318 [details] [diff] [review]
Patch

Review of attachment 8561318 [details] [diff] [review]:
-----------------------------------------------------------------

((Stealing the review ... ))

Thank you, Greg.
Attachment #8561318 - Flags: review?(szchen) → review+
(Assignee)

Comment 6

3 years ago
Created attachment 8562455 [details] [diff] [review]
Patch rev2

I've updated the patch to rebase it and add new review message.
Keeping the old patch to show the review flag is +.
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/84ddb2bacfc0
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox38: --- → fixed
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
Blocks: 1146799
(Assignee)

Updated

3 years ago
No longer blocks: 1146799

Updated

3 years ago
Blocks: 811754
You need to log in before you can comment on or make changes to this bug.