1130938 - B2G RIL: Remove the duplicated RilWorkerBuffer in ril_worker.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Greg Weng [:snowmantw][:gweng][:λ]]

+++ This bug was initially created as a clone of Bug #1123066 +++

Since in Bug 1123066 I did the wrong rebasing so the code still in ril_worker.js, while there is the new, independent ril_worker_buffer.js file. So in this bug I need to remove them from the ril_worker.js.

Comment 1

[Greg Weng [:snowmantw][:gweng][:λ]]

Oh, sorry, cloning bug indicates to the wrong bug. The Bug should be Bug 1123201. This is because it's another cloned bug, too.

Comment 2

[Greg Weng [:snowmantw][:gweng][:λ]]

The try is green:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=60587bb96c08

I'll submit the patch and set the review flag.

Comment 3

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch

Patch: remove the duplicated code.

Comment 4

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8561318 [details] [diff] [review]
Patch

Follow the first bug, set :aknow as the reviewer.

Comment 5

[Edgar Chen [:edgar]]

Comment on attachment 8561318 [details] [diff] [review]
Patch

Review of attachment 8561318 [details] [diff] [review]:
-----------------------------------------------------------------

((Stealing the review ... ))

Thank you, Greg.

Comment 6

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch rev2

I've updated the patch to rebase it and add new review message.
Keeping the old patch to show the review flag is +.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/integration/b2g-inbound/rev/84ddb2bacfc0

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/84ddb2bacfc0