1131492 - [RTL][Dialer]The position of buttons on toolbar is mirrored at active call screen.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P1)

Description

[Sue]

Attachment: toolbar.png

[1.Description]:
[RTL][Dialer]When you MO a call, the position of buttons on toolbar is mirrored, the pause button is left-aligned and mute button is right-aligned.
See attachment:toolbar.png

[2.Testing Steps]: 
Prerequisite: Set system language as Arabic.
1. Launch Phone app.
2. Make a call.
3. Observe the toolbar(such as pause, dailer button).

[3.Expected Result]: 
3. The position of buttons on toolbar should not be mirrored.

[4.Actual Result]: 
3. The position of buttons on toolbar is mirrored.

[5.Reproduction build]: 
Flame 2.2 build:
Build ID               20150209002504
Gaia Revision          e827781324cbde91d2434b388f5dead3303a85ee
Gaia Date              2015-02-06 20:54:14
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/0552759956d3
Gecko Version          37.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150209.040038
Firmware Date          Mon Feb  9 04:00:51 EST 2015
Bootloader             L1TC000118D0

[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
Free Test

Comment 1

[Dylan Oliver [:doliver]]

triage: P1, the toolbar should not be reversed

Comment 2

[Dylan Oliver [:doliver]]

Sue, can you file a new bug for the + sign being in the wrong place on this same screen?

Comment 3

[jlorenzo (disabled)]

(In reply to Dylan Oliver [:doliver] from comment #2)
No need to file a bug for that, bug 1131246 already exists.

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] autra:bug-1131492 > mozilla-b2g:master

Comment 5

[Augustin Trancart [:autra]]

Comment on attachment 8562879 [details] [review]
[gaia] autra:bug-1131492 > mozilla-b2g:master

Hi Gabriel,

Could you review this please? Thanks!

Comment 6

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8562879 [details] [review]
[gaia] autra:bug-1131492 > mozilla-b2g:master

The fix works but I'd rather see the element's direction be set directly in the HTML code instead, see here:

https://github.com/mozilla-b2g/gaia/blob/bc0036116ab2f66dd56bf85e64c879b462311a46/apps/callscreen/index.html#L159

Since this is unconditional I'd rather not add another CSS rule just for it.

Comment 7

[Augustin Trancart [:autra]]

Comment on attachment 8562879 [details] [review]
[gaia] autra:bug-1131492 > mozilla-b2g:master

Indeed it makes sense. Thanks!

Comment 8

[Gabriele Svelto [:gsvelto]]

Comment on attachment 8562879 [details] [review]
[gaia] autra:bug-1131492 > mozilla-b2g:master

Excellent, thanks!

Comment 9

[Doug Sherk (:drs) (inactive)]

Augustin, can this be landed now?

Comment 10

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/86f6acffbd2aeb5899b7592d133fc8713f2a223e

Comment 11

[Augustin Trancart [:autra]]

Comment on attachment 8562879 [details] [review]
[gaia] autra:bug-1131492 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): not a regression (I  think)
[User impact] if declined: button will be in the wrong order, but still usable. Low impact
[Testing completed]: on flame v2.2
[Risk to taking this patch] (and alternatives if risky): very low
[String changes made]: None

Comment 12

[Ryan VanderMeulen [:RyanVM]]

v2.2: https://github.com/mozilla-b2g/gaia/commit/810127202f47a8ea72da5194e0bafeb6f8586f6c

Comment 13

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue is verified fixed on the latest Nightly  Flame KK 3.0 and 2.2 builds.

Actual Results: The icons are not reversed in RTL.

Environmental Variables:
Device: Flame 3.0 KK (Full Flash) (319 MB)
BuildID: 20150223010224
Gaia: a6881205deae450757a8d1e1ed65e5e5be0ec633
Gecko: 86d2bb8bb1c9
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 38.0a1 (3.0) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0

Environmental Variables:
Device: Flame 2.2 KK (Full Flash) (319 MB)
BuildID: 20150223002503
Gaia: 389542b71c89253c0d176d3b0bfb54e275c19bf1
Gecko: 9fd3441c8983
Gonk: e7c90613521145db090dd24147afd5ceb5703190
Version: 37.0a2 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 14

[Alissa（leave from Mozilla）]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15425/