Closed
Bug 1131492
Opened 6 years ago
Closed 6 years ago
[RTL][Dialer]The position of buttons on toolbar is mirrored at active call screen.
Categories
(Firefox OS Graveyard :: Gaia::Dialer, defect, P1)
Tracking
(feature-b2g:2.2+, b2g-v2.2 verified, b2g-master verified)
People
(Reporter: lulu.tian, Assigned: autra)
References
Details
Attachments
(2 files)
222.58 KB,
image/png
|
Details | |
46 bytes,
text/x-github-pull-request
|
gsvelto
:
review+
bajaj
:
approval-gaia-v2.2+
|
Details | Review |
[1.Description]: [RTL][Dialer]When you MO a call, the position of buttons on toolbar is mirrored, the pause button is left-aligned and mute button is right-aligned. See attachment:toolbar.png [2.Testing Steps]: Prerequisite: Set system language as Arabic. 1. Launch Phone app. 2. Make a call. 3. Observe the toolbar(such as pause, dailer button). [3.Expected Result]: 3. The position of buttons on toolbar should not be mirrored. [4.Actual Result]: 3. The position of buttons on toolbar is mirrored. [5.Reproduction build]: Flame 2.2 build: Build ID 20150209002504 Gaia Revision e827781324cbde91d2434b388f5dead3303a85ee Gaia Date 2015-02-06 20:54:14 Gecko Revision https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/0552759956d3 Gecko Version 37.0a2 Device Name flame Firmware(Release) 4.4.2 Firmware(Incremental) eng.cltbld.20150209.040038 Firmware Date Mon Feb 9 04:00:51 EST 2015 Bootloader L1TC000118D0 [6.Reproduction Frequency]: Always Recurrence,5/5 [7.TCID]: Free Test
Comment 1•6 years ago
|
||
triage: P1, the toolbar should not be reversed
feature-b2g: --- → 2.2+
Priority: -- → P1
Comment 2•6 years ago
|
||
Sue, can you file a new bug for the + sign being in the wrong place on this same screen?
Flags: needinfo?(lulu.tian)
Comment 3•6 years ago
|
||
(In reply to Dylan Oliver [:doliver] from comment #2) No need to file a bug for that, bug 1131246 already exists.
Flags: needinfo?(lulu.tian)
Assignee | ||
Updated•6 years ago
|
QA Contact: augustin.trancart
Assignee | ||
Updated•6 years ago
|
QA Contact: augustin.trancart
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → augustin.trancart
Comment 4•6 years ago
|
||
Assignee | ||
Comment 5•6 years ago
|
||
Comment on attachment 8562879 [details] [review] [gaia] autra:bug-1131492 > mozilla-b2g:master Hi Gabriel, Could you review this please? Thanks!
Attachment #8562879 -
Flags: review?(gsvelto)
Comment 6•6 years ago
|
||
Comment on attachment 8562879 [details] [review] [gaia] autra:bug-1131492 > mozilla-b2g:master The fix works but I'd rather see the element's direction be set directly in the HTML code instead, see here: https://github.com/mozilla-b2g/gaia/blob/bc0036116ab2f66dd56bf85e64c879b462311a46/apps/callscreen/index.html#L159 Since this is unconditional I'd rather not add another CSS rule just for it.
Attachment #8562879 -
Flags: review?(gsvelto) → review-
Assignee | ||
Comment 7•6 years ago
|
||
Comment on attachment 8562879 [details] [review] [gaia] autra:bug-1131492 > mozilla-b2g:master Indeed it makes sense. Thanks!
Attachment #8562879 -
Flags: review- → review?(gsvelto)
Updated•6 years ago
|
Status: NEW → ASSIGNED
Comment 8•6 years ago
|
||
Comment on attachment 8562879 [details] [review] [gaia] autra:bug-1131492 > mozilla-b2g:master Excellent, thanks!
Attachment #8562879 -
Flags: review?(gsvelto) → review+
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(augustin.trancart)
Keywords: checkin-needed
Updated•6 years ago
|
Keywords: checkin-needed
Comment 10•6 years ago
|
||
Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/86f6acffbd2aeb5899b7592d133fc8713f2a223e
Updated•6 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 11•6 years ago
|
||
Comment on attachment 8562879 [details] [review] [gaia] autra:bug-1131492 > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): not a regression (I think) [User impact] if declined: button will be in the wrong order, but still usable. Low impact [Testing completed]: on flame v2.2 [Risk to taking this patch] (and alternatives if risky): very low [String changes made]: None
Attachment #8562879 -
Flags: approval-gaia-v2.2?
Updated•6 years ago
|
Attachment #8562879 -
Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
Comment 12•6 years ago
|
||
v2.2: https://github.com/mozilla-b2g/gaia/commit/810127202f47a8ea72da5194e0bafeb6f8586f6c
status-b2g-master:
--- → fixed
Target Milestone: --- → 2.2 S6 (20feb)
Comment 13•6 years ago
|
||
This issue is verified fixed on the latest Nightly Flame KK 3.0 and 2.2 builds. Actual Results: The icons are not reversed in RTL. Environmental Variables: Device: Flame 3.0 KK (Full Flash) (319 MB) BuildID: 20150223010224 Gaia: a6881205deae450757a8d1e1ed65e5e5be0ec633 Gecko: 86d2bb8bb1c9 Gonk: e7c90613521145db090dd24147afd5ceb5703190 Version: 38.0a1 (3.0) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0 Environmental Variables: Device: Flame 2.2 KK (Full Flash) (319 MB) BuildID: 20150223002503 Gaia: 389542b71c89253c0d176d3b0bfb54e275c19bf1 Gecko: 9fd3441c8983 Gonk: e7c90613521145db090dd24147afd5ceb5703190 Version: 37.0a2 (2.2) Firmware Version: v18D-1 User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
QA Whiteboard: [rtl-impact] → [QAnalyst-Triage?][rtl-impact]
Flags: needinfo?(ktucker)
Updated•6 years ago
|
Updated•6 years ago
|
QA Whiteboard: [QAnalyst-Triage?][rtl-impact] → [QAnalyst-Triage+][rtl-impact]
Flags: needinfo?(ktucker)
Comment 14•6 years ago
|
||
Test case has been added in moztrap: https://moztrap.mozilla.org/manage/case/15425/
Flags: in-moztrap+
You need to log in
before you can comment on or make changes to this bug.
Description
•