Color/background-color of preedit string is always default(we should not use invert)

RESOLVED FIXED in mozilla1.9alpha1

Status

()

P1
normal
RESOLVED FIXED
17 years ago
8 years ago

People

(Reporter: kazhik, Assigned: masayuki)

Tracking

(Blocks: 1 bug, {inputmethod, intl})

Trunk
mozilla1.9alpha1
inputmethod, intl
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 9 obsolete attachments)

(Reporter)

Description

17 years ago
Color/background-color of preedit string is always default color.

<style>
textarea,input {
   background-color:#909090;
   color:#ffffff;
}
</style>

In textarea or input with this style, color/background-color of preedit 
string should be changed from default.

Original report in Bugzilla-jp:
http://bugzilla.mozilla.gr.jp/show_bug.cgi?id=1540

Comment 1

17 years ago
I'm not very familiar with Linux nor Mac IME APIs. 
so cc'ing shanjian and nhotta.


Status: NEW → ASSIGNED
Priority: -- → P3

Updated

17 years ago
Target Milestone: --- → mozilla0.9.8

Updated

17 years ago
Target Milestone: mozilla0.9.8 → mozilla1.0.1

Comment 2

17 years ago
please put a test cases here.
(Reporter)

Comment 3

17 years ago
Created attachment 71134 [details]
Testcase
(Assignee)

Updated

14 years ago
Depends on: 56314, 170951
(Assignee)

Updated

14 years ago
Summary: Color/background-color of preedit string is always default → Color/background-color of preedit string is always default(we should not use invert)
(Assignee)

Updated

14 years ago
Assignee: yokoyama → masayuki
Status: ASSIGNED → NEW
QA Contact: teruko → amyy
Target Milestone: mozilla1.0.1 → ---
(Assignee)

Updated

14 years ago
Blocks: 290919
(Assignee)

Updated

14 years ago
Status: NEW → ASSIGNED
Keywords: intl
Target Milestone: --- → mozilla1.9alpha
(Assignee)

Updated

14 years ago
Priority: P3 → P1
(Assignee)

Updated

13 years ago
Blocks: 292191
(Assignee)

Updated

13 years ago
Depends on: 307396
(Assignee)

Updated

13 years ago
Depends on: 307532
Created attachment 202062 [details] [diff] [review]
Patch rv1.0
Attachment #202062 - Flags: superreview?(roc)
Attachment #202062 - Flags: review?(roc)
Comment on attachment 202062 [details] [diff] [review]
Patch rv1.0

Sorry. This patch has warning message.
Attachment #202062 - Flags: superreview?(roc)
Attachment #202062 - Flags: review?(roc)
Attachment #202062 - Flags: review-
Created attachment 202064 [details] [diff] [review]
Patch rv1.1
Attachment #202062 - Attachment is obsolete: true
Attachment #202064 - Flags: superreview?(roc)
Attachment #202064 - Flags: review?(roc)
This patch uses the system IME composition string color in nsTextFrame.cpp.
And this removes dirty non-XP code from |PaintTextDecorations|.
And this fixes both this and bug 170951.
The code that converts foreColor and lineColor should be factored out into its own function.

The per-IME-index values should be a single array of structs.

Other than that it looks pretty good!
(Assignee)

Updated

13 years ago
Attachment #202064 - Flags: superreview?(roc)
Attachment #202064 - Flags: review?(roc)
Attachment #202064 - Flags: review-
Created attachment 202780 [details] [diff] [review]
Patch rv1.2
Attachment #202064 - Attachment is obsolete: true
Attachment #202780 - Flags: superreview?(roc)
Attachment #202780 - Flags: review?(roc)
Comment on attachment 202780 [details] [diff] [review]
Patch rv1.2

Sorry.
Attachment #202780 - Flags: superreview?(roc)
Attachment #202780 - Flags: review?(roc)
Created attachment 202781 [details] [diff] [review]
Patch rv1.2
Attachment #202780 - Attachment is obsolete: true
Attachment #202781 - Flags: superreview?(roc)
Attachment #202781 - Flags: review?(roc)

Comment 13

13 years ago
Off-Topic: Masayuki, this latest Bugzilla version automatically cancels pending review requests when you mark the patch as obsolete, so no need to manually remove review requests if you're going to mark it as obsolete anyway.
Caleb: Thank you.
Comment on attachment 202781 [details] [diff] [review]
Patch rv1.2

Sorry. I don't like this patch. There is no reason for using index of array. We should use pointer for the struct instead.
Attachment #202781 - Flags: superreview?(roc)
Attachment #202781 - Flags: review?(roc)
Attachment #202781 - Flags: review-
Created attachment 202950 [details] [diff] [review]
Patch rv1.3
Attachment #202781 - Attachment is obsolete: true
Attachment #202950 - Flags: superreview?(roc)
Attachment #202950 - Flags: review?(roc)
Created attachment 202951 [details] [diff] [review]
Patch rv1.3.1
Attachment #202950 - Attachment is obsolete: true
Attachment #202951 - Flags: superreview?(roc)
Attachment #202951 - Flags: review?(roc)
Attachment #202950 - Flags: superreview?(roc)
Attachment #202950 - Flags: review?(roc)
Created attachment 202952 [details] [diff] [review]
Patch rv1.4
Attachment #202951 - Attachment is obsolete: true
Attachment #202952 - Flags: superreview?(roc)
Attachment #202952 - Flags: review?(roc)
Attachment #202951 - Flags: superreview?(roc)
Attachment #202951 - Flags: review?(roc)
Why not just have GetIMEColor do the initialization if it hasn't been done already, instead of forcing its callers to check that?
Created attachment 203495 [details] [diff] [review]
Patch rv1.5
Attachment #202952 - Attachment is obsolete: true
Attachment #203495 - Flags: superreview?(roc)
Attachment #203495 - Flags: review?(roc)
Attachment #202952 - Flags: superreview?(roc)
Attachment #202952 - Flags: review?(roc)
Comment on attachment 203495 [details] [diff] [review]
Patch rv1.5

Oops. This may make bustage with VC6.
Attachment #203495 - Flags: superreview?(roc)
Attachment #203495 - Flags: review?(roc)
Attachment #203495 - Flags: review-
Created attachment 203496 [details] [diff] [review]
Patch rv1.6
Attachment #203495 - Attachment is obsolete: true
Attachment #203496 - Flags: superreview?(roc)
Attachment #203496 - Flags: review?(roc)
+  if (aIMEColor->mInit)
+    return PR_TRUE;
+

Just assert !aIMEColor->mInit. The only caller guarantees this.

+nsTextPaintStyle::Get40PercentColor(nscolor aForeColor, nscolor aBackColor)

Make it a static helper function or just move it up to the caller.

+  if (!mInit && mTypes) {

mTypes is guaranteed to be non-null here. Remove the check.

+
   mInit = PR_TRUE;

Move this up inside the if block.

+  // if this retrun

"return"
Created attachment 203751 [details] [diff] [review]
Patch rv1.7
Attachment #203496 - Attachment is obsolete: true
Attachment #203751 - Flags: superreview?(roc)
Attachment #203751 - Flags: review?(roc)
Attachment #203496 - Flags: superreview?(roc)
Attachment #203496 - Flags: review?(roc)
Attachment #203751 - Flags: superreview?(roc)
Attachment #203751 - Flags: superreview+
Attachment #203751 - Flags: review?(roc)
Attachment #203751 - Flags: review+
checked-in. Thank you!
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
(Assignee)

Updated

12 years ago
No longer blocks: 292191
Keywords: inputmethod
You need to log in before you can comment on or make changes to this bug.